From patchwork Mon Nov 18 18:12:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36012 Received: (qmail 93957 invoked by alias); 18 Nov 2019 18:12:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 93949 invoked by uid 89); 18 Nov 2019 18:12:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2086 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 18:12:48 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 59C42203AC; Mon, 18 Nov 2019 13:12:47 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 62DAE2012A for ; Mon, 18 Nov 2019 13:12:46 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 29EFB2816F for ; Mon, 18 Nov 2019 13:12:46 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 18 Nov 2019 13:12:46 -0500 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs X-Gerrit-Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301 X-Gerrit-Change-Number: 685 X-Gerrit-ChangeURL: X-Gerrit-Commit: 73d9e725f2020058234b9229a711125bebdbdaa0 References: Reply-To: andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685 ...................................................................... gdb/testsuite: Fix minor bug in skip_btrace*tests procs The two guard functions skip_btrace_tests and skip_btrace_pt_tests have a minor bug, if the check function fails to compile then surely we should skip the btrace tests - currently we return 0 to indicate don't skip. gdb/testsuite/ChangeLog: * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to compile. (skip_btrace_pt_tests): Likewise. Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301 --- M gdb/testsuite/ChangeLog M gdb/testsuite/lib/gdb.exp 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3a4d229..a598b23 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2019-11-18 Andrew Burgess + + * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to + compile. + (skip_btrace_pt_tests): Likewise. + 2019-11-14 Tom Tromey * gdb.base/gdbvars.exp (test_convenience_variables): Add diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 2d395ef..3662a61 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2942,7 +2942,7 @@ # Compile a test program. set src { int main() { return 0; } } if {![gdb_simple_compile $me $src executable]} { - return 0 + return 1 } # No error message, compilation succeeded so now run it via gdb. @@ -2993,7 +2993,7 @@ # Compile a test program. set src { int main() { return 0; } } if {![gdb_simple_compile $me $src executable]} { - return 0 + return 1 } # No error message, compilation succeeded so now run it via gdb.