From patchwork Thu Nov 14 23:35:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35907 Received: (qmail 25775 invoked by alias); 14 Nov 2019 23:35:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25697 invoked by uid 89); 14 Nov 2019 23:35:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 23:35:56 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 9AA3320562; Thu, 14 Nov 2019 18:35:54 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id A41A020562 for ; Thu, 14 Nov 2019 18:35:50 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 8FE2E20AF6 for ; Thu, 14 Nov 2019 18:35:50 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 14 Nov 2019 18:35:50 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Remove some TUI asserts X-Gerrit-Change-Id: I807e1e9bdb0cfa475e70375ceca3a5d4f2eb8d0b X-Gerrit-Change-Number: 633 X-Gerrit-ChangeURL: X-Gerrit-Commit: 65c0accf2844b9697f260204efd0e9fb8d2323fe References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/633 ...................................................................... Remove some TUI asserts This removes a few asserts from the TUI. These asserts aren't useful, because they simply check an invariant that's already ensured by the type system. gdb/ChangeLog 2019-11-14 Tom Tromey * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at) (tui_source_window_base::update_breakpoint_info): Remove asserts. Change-Id: I807e1e9bdb0cfa475e70375ceca3a5d4f2eb8d0b --- M gdb/ChangeLog M gdb/tui/tui-winsource.c 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2bd3534..edb8cf0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-11-14 Tom Tromey + * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at) + (tui_source_window_base::update_breakpoint_info): Remove asserts. + +2019-11-14 Tom Tromey + * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call tui_show_disassem. * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index 2cd4b65..8e1d61a 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -442,9 +442,6 @@ struct tui_line_or_address content_loa = content[i].line_or_addr; - gdb_assert (l.loa == LOA_ADDRESS || l.loa == LOA_LINE); - gdb_assert (content_loa.loa == LOA_LINE - || content_loa.loa == LOA_ADDRESS); if (content_loa.loa == l.loa && ((l.loa == LOA_LINE && content_loa.u.line_no == l.u.line_no) || (l.loa == LOA_ADDRESS && content_loa.u.addr == l.u.addr))) @@ -505,9 +502,6 @@ { struct bp_location *loc; - gdb_assert (line->line_or_addr.loa == LOA_LINE - || line->line_or_addr.loa == LOA_ADDRESS); - if (bp == being_deleted) return false;