From patchwork Thu Oct 31 22:51:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35545 Received: (qmail 74536 invoked by alias); 31 Oct 2019 22:51:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 74526 invoked by uid 89); 31 Oct 2019 22:51:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2172 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 22:51:26 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 04A34204F8; Thu, 31 Oct 2019 18:51:24 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id D209C20266 for ; Thu, 31 Oct 2019 18:51:23 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id AF4B4218A2 for ; Thu, 31 Oct 2019 18:51:23 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Thu, 31 Oct 2019 18:51:23 -0400 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Fix up safe_strerror constification X-Gerrit-Change-Id: I2b8be88444ad8b5e92e9d57d28e66874142b72f7 X-Gerrit-Change-Number: 478 X-Gerrit-ChangeURL: X-Gerrit-Commit: 87b1671259bcf7e1a0cd154e47e98f776643adf0 References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/478 ...................................................................... Fix up safe_strerror constification The earlier patch to constify safe_strerror missed a couple of spots, corrected here. gdb/ChangeLog 2019-10-31 Tom Tromey * gdbsupport/mingw-strerror.c (safe_strerror): Constify result. * gdbsupport/gdb-dlfcn.c (gdb_dlopen): Update. Change-Id: I2b8be88444ad8b5e92e9d57d28e66874142b72f7 --- M gdb/ChangeLog M gdb/gdbsupport/gdb-dlfcn.c M gdb/gdbsupport/mingw-strerror.c 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 245fcdf..9f34dbc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-10-31 Tom Tromey + * gdbsupport/mingw-strerror.c (safe_strerror): Constify result. + * gdbsupport/gdb-dlfcn.c (gdb_dlopen): Update. + +2019-10-31 Tom Tromey + * gdbsupport/gdb-dlfcn.c (gdb_dlopen): Use safe_strerror. 2019-10-31 Christian Biesinger diff --git a/gdb/gdbsupport/gdb-dlfcn.c b/gdb/gdbsupport/gdb-dlfcn.c index 12a35fe..5cd0486 100644 --- a/gdb/gdbsupport/gdb-dlfcn.c +++ b/gdb/gdbsupport/gdb-dlfcn.c @@ -73,7 +73,7 @@ error (_("Could not load %s: %s"), filename, dlerror()); #else { - char *msg = safe_strerror (GetLastError ()); + const char *msg = safe_strerror (GetLastError ()); error (_("Could not load %s: %s"), filename, msg); } #endif diff --git a/gdb/gdbsupport/mingw-strerror.c b/gdb/gdbsupport/mingw-strerror.c index 6386330..893b7ca 100644 --- a/gdb/gdbsupport/mingw-strerror.c +++ b/gdb/gdbsupport/mingw-strerror.c @@ -28,7 +28,7 @@ unfortunately this includes all socket-related error codes. This replacement tries to find a system-provided error message. */ -char * +const char * safe_strerror (int errnum) { static char *buffer;