From patchwork Thu Oct 31 22:03:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35541 Received: (qmail 99524 invoked by alias); 31 Oct 2019 22:03:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99513 invoked by uid 89); 31 Oct 2019 22:03:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 22:03:29 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8FF98204A6; Thu, 31 Oct 2019 18:03:27 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id D1A6520339; Thu, 31 Oct 2019 18:03:22 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A5AEC20AF6; Thu, 31 Oct 2019 18:03:22 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Thu, 31 Oct 2019 18:03:22 -0400 From: "Christian Biesinger (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Also check for strerror_r in gdbserver X-Gerrit-Change-Id: I6a67c8543cd7a28d6dc94f5986f56abcb55727fe X-Gerrit-Change-Number: 476 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7063a780d33950e396e16f696e6765ad0d8ed788 References: Reply-To: cbiesinger@google.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476 ...................................................................... Also check for strerror_r in gdbserver I forgot to do this in b231e86ac9608056ea837e24d42a878927f5787a Since safe_strerror is in gdbsupport, gdbserver also needs to check for strerror_r, although it's less critical since gdbserver does not use threads as much. gdb/gdbserver/ChangeLog: 2019-10-31 Christian Biesinger * config.in: Regenerate. * configure: Regenerate. * configure.ac: Also check for strerror_r. Change-Id: I6a67c8543cd7a28d6dc94f5986f56abcb55727fe --- M gdb/gdbserver/config.in M gdb/gdbserver/configure M gdb/gdbserver/configure.ac 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/gdbserver/config.in b/gdb/gdbserver/config.in index 0bce18d..2984281 100644 --- a/gdb/gdbserver/config.in +++ b/gdb/gdbserver/config.in @@ -229,6 +229,9 @@ /* Define to 1 if you have the header file. */ #undef HAVE_STDLIB_H +/* Define to 1 if you have the `strerror_r' function. */ +#undef HAVE_STRERROR_R + /* Define to 1 if you have the header file. */ #undef HAVE_STRINGS_H diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index e513fc5..7bf9fa2 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -6448,7 +6448,7 @@ fi -for ac_func in getauxval pread pwrite pread64 setns +for ac_func in getauxval pread pwrite pread64 setns strerror_r do : as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh` ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var" diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac index 7ebc9c3..44fee8b 100644 --- a/gdb/gdbserver/configure.ac +++ b/gdb/gdbserver/configure.ac @@ -90,7 +90,7 @@ sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl netinet/tcp.h arpa/inet.h) AC_FUNC_FORK -AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns) +AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns strerror_r) GDB_AC_COMMON