From patchwork Sun Oct 27 14:10:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35367 Received: (qmail 29575 invoked by alias); 27 Oct 2019 14:10:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29565 invoked by uid 89); 27 Oct 2019 14:10:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT autolearn=ham version=3.3.1 spammy=UD:ada-lang.c, ada-lang.c, adalangc X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Oct 2019 14:10:11 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B95F720E95; Sun, 27 Oct 2019 10:10:08 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 7F58220B46 for ; Sun, 27 Oct 2019 10:10:07 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6068A20AF6 for ; Sun, 27 Oct 2019 10:10:07 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Sun, 27 Oct 2019 10:10:07 -0400 From: "Simon Marchi (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Remove unused includes in ada-*.c files X-Gerrit-Change-Id: I07c2f2237ef0ed5fd9aa855d33711d780794fce2 X-Gerrit-Change-Number: 323 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6a757fb28fe14aeb7bc315916499afe5207165de References: Reply-To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/323 ...................................................................... Remove unused includes in ada-*.c files include-what-you-use reports: ../../../src/binutils-gdb/gdb/ada-lang.c should remove these lines: - #include // lines 43-43 - #include // lines 66-66 - #include "c-lang.h" // lines 33-33 - #include "demangle.h" // lines 23-23 - #include "dictionary.h" // lines 47-47 - #include "gdbsupport/gdb_vecs.h" // lines 53-53 - #include "psymtab.h" // lines 58-58 ../../../src/binutils-gdb/gdb/ada-lang.c should remove these lines: - #include // lines 43-43 - #include // lines 66-66 - #include "c-lang.h" // lines 33-33 - #include "demangle.h" // lines 23-23 - #include "dictionary.h" // lines 47-47 - #include "gdbsupport/gdb_vecs.h" // lines 53-53 - #include "psymtab.h" // lines 58-58 ../../../src/binutils-gdb/gdb/ada-valprint.c should remove these lines: - #include "c-lang.h" // lines 31-31 - #include "demangle.h" // lines 26-26 - #include "infcall.h" // lines 32-32 - #include "objfiles.h" // lines 33-33 - #include "symtab.h" // lines 22-22 Remove these includes. Adding an include for gdbarch.h in ada-valprint.c was necessary, because gdbarch_byte_order wouldn't be found anymore. gdb/ChangeLog: * ada-lang.c: Remove includes. * ada-typeprint.c: Remove includes. * ada-valprint.c: Remove includes. Change-Id: I07c2f2237ef0ed5fd9aa855d33711d780794fce2 --- M gdb/ada-lang.c M gdb/ada-typeprint.c M gdb/ada-valprint.c 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 5b54971..d08a264 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -20,7 +20,6 @@ #include "defs.h" #include -#include "demangle.h" #include "gdb_regex.h" #include "frame.h" #include "symtab.h" @@ -30,7 +29,6 @@ #include "parser-defs.h" #include "language.h" #include "varobj.h" -#include "c-lang.h" #include "inferior.h" #include "symfile.h" #include "objfiles.h" @@ -40,22 +38,18 @@ #include "gdb_obstack.h" #include "ada-lang.h" #include "completer.h" -#include #include "ui-out.h" #include "block.h" #include "infcall.h" -#include "dictionary.h" #include "annotate.h" #include "valprint.h" #include "source.h" #include "observable.h" #include "stack.h" -#include "gdbsupport/gdb_vecs.h" #include "typeprint.h" #include "namespace.h" #include "cli/cli-style.h" -#include "psymtab.h" #include "value.h" #include "mi/mi-common.h" #include "arch-utils.h" @@ -63,7 +57,6 @@ #include "gdbsupport/function-view.h" #include "gdbsupport/byte-vector.h" #include -#include /* Define whether or not the C operator '/' truncates towards zero for differently signed operands (truncation direction is undefined in C). diff --git a/gdb/ada-typeprint.c b/gdb/ada-typeprint.c index c246166..be37925 100644 --- a/gdb/ada-typeprint.c +++ b/gdb/ada-typeprint.c @@ -17,18 +17,9 @@ along with this program. If not, see . */ #include "defs.h" -#include "gdb_obstack.h" #include "bfd.h" /* Binary File Description */ -#include "symtab.h" #include "gdbtypes.h" -#include "expression.h" #include "value.h" -#include "gdbcore.h" -#include "target.h" -#include "command.h" -#include "gdbcmd.h" -#include "language.h" -#include "demangle.h" #include "c-lang.h" #include "cli/cli-style.h" #include "typeprint.h" diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c index 714b625..5ab0365 100644 --- a/gdb/ada-valprint.c +++ b/gdb/ada-valprint.c @@ -19,20 +19,16 @@ #include "defs.h" #include -#include "symtab.h" #include "gdbtypes.h" #include "expression.h" #include "value.h" -#include "demangle.h" #include "valprint.h" #include "language.h" #include "annotate.h" #include "ada-lang.h" -#include "c-lang.h" -#include "infcall.h" -#include "objfiles.h" #include "target-float.h" #include "cli/cli-style.h" +#include "gdbarch.h" static int print_field_values (struct type *, const gdb_byte *, int,