From patchwork Thu Oct 24 16:36:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35279 Received: (qmail 105434 invoked by alias); 24 Oct 2019 16:36:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105426 invoked by uid 89); 24 Oct 2019 16:36:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=correspondence X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Oct 2019 16:36:36 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 511D820468; Thu, 24 Oct 2019 12:36:33 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 46659202DF for ; Thu, 24 Oct 2019 12:36:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 1D84A204C9 for ; Thu, 24 Oct 2019 12:36:29 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Thu, 24 Oct 2019 12:36:28 -0400 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Document m68k floating point feature correspondence X-Gerrit-Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f X-Gerrit-Change-Number: 281 X-Gerrit-ChangeURL: X-Gerrit-Commit: f3c479a03c74ef52a95d5489fe159347ea9e3e83 References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/281 ...................................................................... Document m68k floating point feature correspondence From what I can tell, The m68k floating point target feature should apparently always be called "org.gnu.gdb.coldfire.fp" -- even when the primary feature is not "coldfire", because m68k_gdbarch_init only checks for this feature when assigning register numbers. However, the floating point registers are expected to match what gdb thinks are the register sizes for the primary feature. For example, if the main feature is "coldfire", then the floating point registers should be 64 bits. See this note for some an instance of this confusion: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg04564.html This patch documents the oddity. Let me know what you think. An alternate approach here might be to make gdb adapt to the register sizes as actually reported. I'm not sure if this makes sense or not. gdb/doc/ChangeLog 2019-10-24 Tom Tromey * gdb.texinfo (M68K Features): Document floating-point feature correspondence. Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f --- M gdb/doc/ChangeLog M gdb/doc/gdb.texinfo 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 0d0d905..2b80699 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2019-10-24 Tom Tromey + + * gdb.texinfo (M68K Features): Document floating-point feature + correspondence. + 2019-10-23 Tom Tromey * Makefile.in (READLINE_DIR): Update. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 1208e4f..1fbf349 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -44346,6 +44346,12 @@ This feature is optional. If present, it should contain registers @samp{fp0} through @samp{fp7}, @samp{fpcontrol}, @samp{fpstatus} and @samp{fpiaddr}. + +Note that, despite the fact that this feature's name says +@samp{coldfire}, it is used to describe any floating point registers. +The size of the registers must match the main m68k flavor; so, for +example, if the primary feature is reported as @samp{coldfire}, then +64-bit floating point registers are required. @end table @node NDS32 Features