From patchwork Tue Oct 22 20:01:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35233 Received: (qmail 104468 invoked by alias); 22 Oct 2019 20:01:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 104409 invoked by uid 89); 22 Oct 2019 20:01:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 20:01:10 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D7A8F20172; Tue, 22 Oct 2019 16:01:08 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 804CC2018B; Tue, 22 Oct 2019 16:01:06 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6746E2192E; Tue, 22 Oct 2019 16:01:02 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 22 Oct 2019 16:01:02 -0400 From: "Christian Biesinger (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Make demangled_name_entry::language not a bitfield X-Gerrit-Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388 X-Gerrit-Change-Number: 221 X-Gerrit-ChangeURL: X-Gerrit-Commit: 765cecc835f2a39a348adbe2f2e056ae9761bfe2 References: Reply-To: cbiesinger@google.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/221 ...................................................................... Make demangled_name_entry::language not a bitfield Having it as a bitfield causes extra work, and this is not memory-sensitive. Furthermore, once https://sourceware.org/ml/gdb-patches/2019-10/msg00812.html lands, the bitfield won't even save any memory at all. gdb/ChangeLog: 2019-10-22 Christian Biesinger * symtab.c (struct demangled_name_entry) : Change from bitfield to regular variable. Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388 --- M gdb/symtab.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index ed55cec..0a87fec 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -719,7 +719,7 @@ : mangled (mangled_name) {} gdb::string_view mangled; - ENUM_BITFIELD(language) language : LANGUAGE_BITS; + enum language language; char demangled[1]; };