diff mbox

[review] Make demangled_name_entry::language not a bitfield

Message ID gerrit.1571774456000.I4ea31d1cfcbe0f09a09bd058cd304862308dc388@gnutoolchain-gerrit.osci.io
State New
Headers show

Commit Message

Simon Marchi (Code Review) Oct. 22, 2019, 8:01 p.m. UTC
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/221
......................................................................

Make demangled_name_entry::language not a bitfield

Having it as a bitfield causes extra work, and this is not memory-sensitive.
Furthermore, once https://sourceware.org/ml/gdb-patches/2019-10/msg00812.html
lands, the bitfield won't even save any memory at all.

gdb/ChangeLog:

2019-10-22  Christian Biesinger  <cbiesinger@google.com>

	* symtab.c (struct demangled_name_entry) <language>: Change from
	bitfield to regular variable.

Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388
---
M gdb/symtab.c
1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Marchi (Code Review) Oct. 22, 2019, 8:06 p.m. UTC | #1
Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/221
......................................................................


Patch Set 1: Code-Review+2
diff mbox

Patch

diff --git a/gdb/symtab.c b/gdb/symtab.c
index ed55cec..0a87fec 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -719,7 +719,7 @@ 
     : mangled (mangled_name) {}
 
   gdb::string_view mangled;
-  ENUM_BITFIELD(language) language : LANGUAGE_BITS;
+  enum language language;
   char demangled[1];
 };