From patchwork Sun Oct 20 03:55:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35168 Received: (qmail 10403 invoked by alias); 20 Oct 2019 03:55:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 10356 invoked by uid 89); 20 Oct 2019 03:55:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Oct 2019 03:55:19 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8DCE62018E; Sat, 19 Oct 2019 23:55:17 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id E717D2018E for ; Sat, 19 Oct 2019 23:55:11 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C9B5120AF7 for ; Sat, 19 Oct 2019 23:55:11 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Sat, 19 Oct 2019 23:55:11 -0400 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Check for sigprocmask in common.m4 X-Gerrit-Change-Id: I2c0a4dd2c376507b9483b38707a242382faa8163 X-Gerrit-Change-Number: 165 X-Gerrit-ChangeURL: X-Gerrit-Commit: faed476f225cec562877ba1dbe52f0dac3dbbbca References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/165 ...................................................................... Check for sigprocmask in common.m4 I noticed that gdbsupport uses HAVE_SIGPROCMASK, but common.m4 does not check for it. This means that gdbserver may not compile some gdbsupport code properly. This patch fixes this error. gdb/ChangeLog 2019-10-19 Tom Tromey * configure: Rebuild. * configure.ac: Don't check for sigprocmask. * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask. gdb/gdbserver/ChangeLog 2019-10-19 Tom Tromey * configure, config.in: Rebuild. Change-Id: I2c0a4dd2c376507b9483b38707a242382faa8163 --- M gdb/ChangeLog M gdb/configure M gdb/configure.ac M gdb/gdbserver/ChangeLog M gdb/gdbserver/config.in M gdb/gdbserver/configure M gdb/gdbsupport/common.m4 7 files changed, 21 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c4d402f..731f81c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,6 +1,12 @@ 2019-10-19 Tom Tromey * configure: Rebuild. + * configure.ac: Don't check for sigprocmask. + * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask. + +2019-10-19 Tom Tromey + + * configure: Rebuild. * acinclude.m4: Use m4_include, not sinclude. 2019-10-19 Sergio Durigan Junior diff --git a/gdb/configure b/gdb/configure index 70ce52f..36460b8 100755 --- a/gdb/configure +++ b/gdb/configure @@ -13120,7 +13120,7 @@ for ac_func in getauxval getrusage getuid getgid \ pipe poll pread pread64 pwrite resize_term \ sbrk getpgid setpgid setpgrp setsid \ - sigaction sigprocmask sigsetmask socketpair \ + sigaction sigsetmask socketpair \ ttrace wborder wresize setlocale iconvlist libiconvlist btowc \ setrlimit getrlimit posix_madvise waitpid \ ptrace64 sigaltstack setns use_default_colors @@ -13529,7 +13529,8 @@ done - for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction + for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \ + sigprocmask do : as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh` ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var" diff --git a/gdb/configure.ac b/gdb/configure.ac index c4e0dbf..238a934 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1363,7 +1363,7 @@ AC_CHECK_FUNCS([getauxval getrusage getuid getgid \ pipe poll pread pread64 pwrite resize_term \ sbrk getpgid setpgid setpgrp setsid \ - sigaction sigprocmask sigsetmask socketpair \ + sigaction sigsetmask socketpair \ ttrace wborder wresize setlocale iconvlist libiconvlist btowc \ setrlimit getrlimit posix_madvise waitpid \ ptrace64 sigaltstack setns use_default_colors]) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 02033ae..e3a7ebe 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,9 @@ 2019-10-19 Tom Tromey + * configure, config.in: Rebuild. + +2019-10-19 Tom Tromey + * configure: Rebuild. * acinclude.m4: Use m4_include, not sinclude. diff --git a/gdb/gdbserver/config.in b/gdb/gdbserver/config.in index f05e9be..0bce18d 100644 --- a/gdb/gdbserver/config.in +++ b/gdb/gdbserver/config.in @@ -211,6 +211,9 @@ /* Define to 1 if you have the header file. */ #undef HAVE_SIGNAL_H +/* Define to 1 if you have the `sigprocmask' function. */ +#undef HAVE_SIGPROCMASK + /* Define if sigsetjmp is available. */ #undef HAVE_SIGSETJMP diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index 5c84eeb..e513fc5 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -6821,7 +6821,8 @@ done - for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction + for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \ + sigprocmask do : as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh` ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var" diff --git a/gdb/gdbsupport/common.m4 b/gdb/gdbsupport/common.m4 index 9038894..471d705 100644 --- a/gdb/gdbsupport/common.m4 +++ b/gdb/gdbsupport/common.m4 @@ -32,7 +32,8 @@ termios.h dnl dlfcn.h) - AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction]) + AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \ + sigprocmask]) AC_CHECK_DECLS([strerror, strstr])