From patchwork Fri Apr 5 12:21:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88083 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D33FA384514A for ; Fri, 5 Apr 2024 12:22:36 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E9D583846070 for ; Fri, 5 Apr 2024 12:21:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9D583846070 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9D583846070 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712319707; cv=none; b=ryGnSJ97jCTgdYygmXfrw30e1VifLYAUI2ekxlPHTY8O34PZhFW21ub1ELX1S7Q0CzvAQInYJiHfZVDwR8AtInOLYY0owQ1DF9YcAmoiBnV+tcQhp4Cbu2hNoACSIqRTLInKcVWBc2pbeB1QGvIcgbCtW/Gox6FiusW+Kfy+zUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712319707; c=relaxed/simple; bh=lZzuZwgjhPs1wga7Ee/pGpJIbGTwgvW8AMHUY+lSaUc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=bZVaUHW6+zsEsKU5veW7PqapCBJaH48rRKDCv/xgYJUb8R1KsSyMLBKad8FcuQoRgaw8FnG6SS9eoXLh5r4HgZMp/vYKUFVyzdmcES+unNDpxwbZR2HfUZySYVQd7JfUlcRQgKQ6hDZNYTGc8jqkP1NaNgEM9JsGFjC8vJbdBfQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712319703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jm6xj4maMt+PJAfNxk78/KuZGtOT+iw+xRBt9835T/s=; b=ENbgVW2M94O0SwC6Pq7E6tiK3RwoUDahiHmpvXXsgGxLZoP2uPkf1ZNGVk3pXtsxJSz2hK hyMXWmGNjS58NKi+Uw4J1tYLCFoNHAz0NqbveQPaZVimkCeuZHGIuceADW1dvxfkrcrhR3 joRB7kzSCZ/kC6+mipfYSS5yKBJ/nr4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-915LI5i6MzmvU4fZEXgsRA-1; Fri, 05 Apr 2024 08:21:42 -0400 X-MC-Unique: 915LI5i6MzmvU4fZEXgsRA-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5685d83ec51so926566a12.3 for ; Fri, 05 Apr 2024 05:21:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712319699; x=1712924499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jm6xj4maMt+PJAfNxk78/KuZGtOT+iw+xRBt9835T/s=; b=vQnM7OR+GJNaIHfEnVM7ljxHfyp/vh3FBBZb+sjDPv6Eh/CdhnRB6u4S1gA2vGlXin Al3RQ2SmC5AyO/vGfgKKhzFMZO/JlRij8xl+9VypSPY1wkfrzqWMKEi/uAMuHMfBZdvM SOdi2icBNfe9cJK57E5Z3GH+Mir7vnpvkxkcgzD4J6/yP7BqKm0kU3K8/7+PlkjF2MD7 6JRmDFBu+ZFLLteEo64LOfWQDX3o4bH/hDkqJUKhoNJB3SG5QFNpOu+y8bcpQIczxmqw NdGSOqOs+wjFbWU9l6lubKBj96Ej+9Tv/woHHMolVZoqFDdJlQlwate0BoCvlrHu33hg h7zw== X-Gm-Message-State: AOJu0Yx+95OTAnLNyFXzhHoVbWZoFRqCW5VQpvpjMQD5KDdwHufqlZyf a/wzYDMJNtMOXxP4ByVEoTZJ0rEZf9fl1sKNJssx9/Isa/eChAwkjzNdV7IarA4nzgnmC6tFpkv BXb6G2erCojXNQhKT9ySeGGEcpBFwsj5KD6J2GnBjc0YMghyFFIQH0L+KKCjNM5Eskzk/wxteJQ NGMwtovb8TmmV7sX7rDoguDgiRbTBTJbJfyWZMYXcnG/E= X-Received: by 2002:a50:9b19:0:b0:56d:fbea:40ae with SMTP id o25-20020a509b19000000b0056dfbea40aemr785085edi.23.1712319699509; Fri, 05 Apr 2024 05:21:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHE4mG/CKbH/ENLMyQkqGJdRSqsnNs5Kz9kxITzDL5KGtw9cUGdjerE26vfY/1Q9zyjAF1JoA== X-Received: by 2002:a50:9b19:0:b0:56d:fbea:40ae with SMTP id o25-20020a509b19000000b0056dfbea40aemr785063edi.23.1712319698968; Fri, 05 Apr 2024 05:21:38 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id h23-20020aa7c617000000b0056c1c4b870asm750080edq.16.2024.04.05.05.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 05:21:37 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 4/4] gdb/Makefile: Print 'GEN' message, and pass SILENT_FLAG more Date: Fri, 5 Apr 2024 13:21:28 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The targets that use config.status to regenerate themselves don't currently follow the silent rules that the rest of GDB's Makefile does. For example, touch the gdb/gcore.in file and then 'make all' in the gdb/ directory prints: /bin/sh config.status gcore config.status: creating gcore In this commit I make use of the silent-rules.mk mechanism for these targets, now we get: GEN gcore Which matches the rest of our Makefile. Obviously, if you pass 'V=1' to the build then you'll get the old output back. There's no change in what is generated after this commit. --- gdb/Makefile.in | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index c1b3144b175..e9a6247c38d 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2307,31 +2307,31 @@ subdir_do: force done Makefile: Makefile.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ .PHONY: run run: Makefile ./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS) jit-reader.h: $(srcdir)/jit-reader.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ gcore: $(srcdir)/gcore.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ config.h: stamp-h ; @true stamp-h: $(srcdir)/config.in config.status - $(SHELL) config.status config.h + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) config.h nm.h: stamp-nmh ; @true stamp-nmh: config.status - $(SHELL) config.status nm.h + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) nm.h # Files included from config.status or the configure script. When # these change the configure script doesn't need regenerating, but its @@ -2345,7 +2345,7 @@ config_status_deps = \ $(srcdir)/../bfd/config.bfd config.status: $(config_status_deps) - $(SHELL) config.status --recheck + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) --recheck ACLOCAL = aclocal