From patchwork Wed Mar 27 21:33:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 32013 Received: (qmail 96964 invoked by alias); 27 Mar 2019 21:34:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 96910 invoked by uid 89); 27 Mar 2019 21:34:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=unavailable version=3.3.1 spammy=dropping X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 21:34:35 +0000 Received: by mail-wm1-f65.google.com with SMTP id a184so1467775wma.2 for ; Wed, 27 Mar 2019 14:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=nDKfXHbSMke00WyhNKDzAv4jvLMi6YnpQnpD9U8ougk=; b=AOM/luJ/e6V1ENLkLh8OriLJnw5YABZiExIqckR28dgtW4mPNzqm+uq9bEHF+Anaeg MqJmHIXI11OOFA6nabmc0zZwyPZ2d4+2rVXgYA+97M5Y0Tch1kdti17Gairggi9qVhRk JhohbR3mRIjPoe4GzWHUh+So2kvvd1hI1gBXyWhZPCBO1+945JjYWguUT8531jCqeQU8 XBbVuK0Ei+I/PuWMaxiyU7CYCOwYT+JwN+n+sGJYQBFBpywA+hcaOgSDl7bSzRFjHCad ABdc9bA6DjdKfoASyaz922uArbG8mhZEa4YnSpW48mZ2np9rY+SviHbUh1ynR6sp2FmV SB6g== Return-Path: Received: from localhost (host81-151-161-58.range81-151.btcentralplus.com. [81.151.161.58]) by smtp.gmail.com with ESMTPSA id t81sm1903103wmb.5.2019.03.27.14.34.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 14:34:32 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: kevinb@redhat.com, macro@linux-mips.org, brobecker@adacore.com, green@moxielogic.com, qiyao@sourceware.org, shorne@gmail.com, Andrew Burgess Subject: [PATCH 03/25] gdb/m32c: Use default gdbarch methods where possible Date: Wed, 27 Mar 2019 21:33:59 +0000 Message-Id: In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes Make use of the default gdbarch methods for gdbarch_dummy_id, gdbarch_unwind_pc, and gdbarch_unwind_sp where possible. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. gdb/ChangeLog: * m32c-tdep.c (m32c_unwind_pc): Delete. (m32c_unwind_sp): Delete. (m32c_dummy_id): Delete. (m32c_gdbarch_init): Don't register deleted functions with gdbarch. --- gdb/ChangeLog | 8 ++++++++ gdb/m32c-tdep.c | 34 ---------------------------------- 2 files changed, 8 insertions(+), 34 deletions(-) diff --git a/gdb/m32c-tdep.c b/gdb/m32c-tdep.c index 709d33dbd66..a28c5d8e81f 100644 --- a/gdb/m32c-tdep.c +++ b/gdb/m32c-tdep.c @@ -1951,22 +1951,6 @@ static const struct frame_unwind m32c_unwind = { default_frame_sniffer }; - -static CORE_ADDR -m32c_unwind_pc (struct gdbarch *arch, struct frame_info *next_frame) -{ - struct gdbarch_tdep *tdep = gdbarch_tdep (arch); - return frame_unwind_register_unsigned (next_frame, tdep->pc->num); -} - - -static CORE_ADDR -m32c_unwind_sp (struct gdbarch *arch, struct frame_info *next_frame) -{ - struct gdbarch_tdep *tdep = gdbarch_tdep (arch); - return frame_unwind_register_unsigned (next_frame, tdep->sp->num); -} - /* Inferior calls. */ @@ -2139,21 +2123,6 @@ m32c_push_dummy_call (struct gdbarch *gdbarch, struct value *function, } -static struct frame_id -m32c_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - /* This needs to return a frame ID whose PC is the return address - passed to m32c_push_dummy_call, and whose stack_addr is the SP - m32c_push_dummy_call returned. - - m32c_unwind_sp gives us the CFA, which is the value the SP had - before the return address was pushed. */ - struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); - CORE_ADDR sp = get_frame_register_unsigned (this_frame, tdep->sp->num); - return frame_id_build (sp, get_frame_pc (this_frame)); -} - - /* Return values. */ @@ -2643,8 +2612,6 @@ m32c_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) /* Prologue analysis and unwinding. */ set_gdbarch_inner_than (gdbarch, core_addr_lessthan); set_gdbarch_skip_prologue (gdbarch, m32c_skip_prologue); - set_gdbarch_unwind_pc (gdbarch, m32c_unwind_pc); - set_gdbarch_unwind_sp (gdbarch, m32c_unwind_sp); #if 0 /* I'm dropping the dwarf2 sniffer because it has a few problems. They may be in the dwarf2 cfi code in GDB, or they may be in @@ -2658,7 +2625,6 @@ m32c_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) /* Inferior calls. */ set_gdbarch_push_dummy_call (gdbarch, m32c_push_dummy_call); set_gdbarch_return_value (gdbarch, m32c_return_value); - set_gdbarch_dummy_id (gdbarch, m32c_dummy_id); /* Trampolines. */ set_gdbarch_skip_trampoline_code (gdbarch, m32c_skip_trampoline_code);