diff mbox

[v1] gdbsupport: Fix setting up 'development' var.

Message ID d851ec32-e6c7-99cf-e2a0-6783ccb2a36b@gmail.com
State New
Headers show

Commit Message

Vyacheslav Petrishchev Feb. 26, 2020, 7:40 a.m. UTC
On 2/26/20 3:17 AM, Christian Biesinger wrote:
> Oh, that explains the error someone mentioned on IRC recently...
> 
> I can't approve patches, but it looks like you used Debian's autoconf
> to regenerate the configure script, leading to extra changes. To avoid
> that it is best if you install and use an unmodified upstream autoconf
> directly, perhaps by installing with --prefix and running it from
> there.
> 
> Christian
> 

yes, it was Debian's autoconf, thanks

Vyacheslav

Comments

Simon Marchi March 5, 2020, 7:36 p.m. UTC | #1
On 2020-02-26 2:40 a.m., Vyacheslav Petrishchev wrote:
> 
> 
> On 2/26/20 3:17 AM, Christian Biesinger wrote:
>> Oh, that explains the error someone mentioned on IRC recently...
>>
>> I can't approve patches, but it looks like you used Debian's autoconf
>> to regenerate the configure script, leading to extra changes. To avoid
>> that it is best if you install and use an unmodified upstream autoconf
>> directly, perhaps by installing with --prefix and running it from
>> there.
>>
>> Christian
>>
> 
> yes, it was Debian's autoconf, thanks
> 
> Vyacheslav
> 

Thanks, I hadn't noticed before now you provided an updated patch.

I added a commit message to it and pushed it.

You can check my series here which does a bit of further cleanup in that area:

  https://sourceware.org/ml/gdb-patches/2020-03/msg00123.html

Simon
diff mbox

Patch

From aa728d759ffee93698c282003e532398de2a6000 Mon Sep 17 00:00:00 2001
From: Vyacheslav Petrishchev <vyachemail@gmail.com>
Date: Wed, 26 Feb 2020 12:32:03 +0600
Subject: gdbsupport: Fix setting up 'development' var.

gdbsupport/ChangeLog:

        * configure.ac: Added call development.sh.
        * configure: Regenerate.
---
 gdbsupport/ChangeLog    | 5 +++++
 gdbsupport/configure    | 3 +++
 gdbsupport/configure.ac | 3 +++
 3 files changed, 11 insertions(+)

diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index d01966ed1d..e1d4853df7 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,8 @@ 
+2020-02-25  Vyacheslav Petrishchev <vyachemail@gmail.com>
+
+	* configure.ac: Added call development.sh.
+	* configure: Regenerate.
+
 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* configure: Regenerate.
diff --git a/gdbsupport/configure b/gdbsupport/configure
index a4871f8d5b..e7a99e3ddf 100755
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -6569,6 +6569,9 @@  fi
 am_cv_prog_cc_stdc=$ac_cv_prog_cc_stdc
 
 
+# Set the 'development' global.
+. $srcdir/../bfd/development.sh
+
 # We require a C++11 compiler.  Check if one is available, and if
 # necessary, set CXX_DIALECT to some -std=xxx switch.
 
diff --git a/gdbsupport/configure.ac b/gdbsupport/configure.ac
index 401e16f821..ab71a3cb36 100644
--- a/gdbsupport/configure.ac
+++ b/gdbsupport/configure.ac
@@ -33,6 +33,9 @@  AC_USE_SYSTEM_EXTENSIONS
 ACX_LARGEFILE
 AM_PROG_CC_STDC
 
+# Set the 'development' global.
+. $srcdir/../bfd/development.sh
+
 # We require a C++11 compiler.  Check if one is available, and if
 # necessary, set CXX_DIALECT to some -std=xxx switch.
 AX_CXX_COMPILE_STDCXX(11, , mandatory)
-- 
2.20.1