From patchwork Thu May 18 15:46:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preud'homme X-Patchwork-Id: 20488 Received: (qmail 66928 invoked by alias); 18 May 2017 15:46:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 66661 invoked by uid 89); 18 May 2017 15:46:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 May 2017 15:46:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32E12344; Thu, 18 May 2017 08:46:51 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF6813F41F; Thu, 18 May 2017 08:46:50 -0700 (PDT) Subject: Re: [PATCH, GDB] Expect prompt after no FPU warning To: Yao Qi References: <861srnadl8.fsf@gmail.com> <0e2b3698-2ee8-0b08-173d-ce60f0602677@foss.arm.com> <86wp9f8v4g.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Thomas Preudhomme Message-ID: Date: Thu, 18 May 2017 16:46:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <86wp9f8v4g.fsf@gmail.com> X-IsSubscribed: yes FYI On 17/05/17 14:34, Yao Qi wrote: > Thomas Preudhomme writes: > >> Is this ok for master branch and GDB 8 (after a 1 week period)? >> > > Patch is good to me, one comment below. > > GDB 8 will be released soon, so it is good to have this patch in 8.0. > This patch is about test case, so it should be safe to merge it to 8.0 > branch now. > >> - gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)" >> + gdb_test "info float" "No floating.point info available for this processor.*$gdb_prompt $" "info float (unknown target)" >> } > > This change is not needed, because $gdb_prompt is appended in the > pattern inside of gdb_test. > Alright, pushed the attached patch which also fix a spurious codestyle change (tab - space) to master and GDB 8. Best regards, Thomas diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp index a4762c9742682391074f0707e56a6eae4cd70c6e..e09c124b8825d687cd0bac9f363b0b61b0ed9230 100644 --- a/gdb/testsuite/gdb.base/float.exp +++ b/gdb/testsuite/gdb.base/float.exp @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then { # if we have NEON. pass "info float (VFP)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -63,7 +63,7 @@ if { [is_aarch64_target] } then { -re "fp0.*fp1.*fp7.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -81,7 +81,7 @@ if { [is_aarch64_target] } then { -re "fd0.*fd3.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -90,7 +90,7 @@ if { [is_aarch64_target] } then { -re "f0.*f1.*f31.*fpscr.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } } @@ -102,7 +102,7 @@ if { [is_aarch64_target] } then { -re "fpul.*fr0.*fr1.*fr15.*$gdb_prompt $" { pass "info float (with FPU)" } - -re "No floating.point info available for this processor.*" { + -re "No floating.point info available for this processor.*$gdb_prompt $" { pass "info float (without FPU)" } }