[v5,3/4] gdb: testsuite: Add or1k l.nop inscruction

Message ID d3d7f61042f7fdd9aa8cea88524249acfd43841b.1489728533.git.shorne@gmail.com
State New, archived
Headers

Commit Message

Stafford Horne March 17, 2017, 5:43 a.m. UTC
  The test case requires adding a nop instruction.  For or1k the
instruction is `l.nop`. This change uses the correct operation.

gdb/testsuite/ChangeLog:

2016-05-11  Stafford Horne  <shorne@gmail.com>

	* gdb.base/bp-permanent.c: Define nop of or1k.
---
 gdb/testsuite/gdb.base/bp-permanent.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Yao Qi April 4, 2017, 9:29 p.m. UTC | #1
Stafford Horne <shorne@gmail.com> writes:

> gdb/testsuite/ChangeLog:
>
> 2016-05-11  Stafford Horne  <shorne@gmail.com>
>
> 	* gdb.base/bp-permanent.c: Define nop of or1k.

The patch is good to me, but do you need to add or1k in
gdb.xml/tdesc-regs.exp?
  

Patch

diff --git a/gdb/testsuite/gdb.base/bp-permanent.c b/gdb/testsuite/gdb.base/bp-permanent.c
index acd5be7..d42aafa 100644
--- a/gdb/testsuite/gdb.base/bp-permanent.c
+++ b/gdb/testsuite/gdb.base/bp-permanent.c
@@ -26,6 +26,8 @@ 
 
 #if defined(__s390__) || defined(__s390x__)
 #define NOP asm("nopr 0")
+#elif defined(__or1k__)
+#define NOP asm("l.nop")
 #else
 #define NOP asm("nop")
 #endif