From patchwork Tue Sep 18 10:40:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hafiz Abid Qadeer X-Patchwork-Id: 29435 Received: (qmail 64065 invoked by alias); 18 Sep 2018 10:40:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64041 invoked by uid 89); 18 Sep 2018 10:40:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=codesourcery X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 10:40:51 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1g2DR3-00034Y-UU from abid_qadeer@mentor.com for gdb-patches@sourceware.org; Tue, 18 Sep 2018 03:40:50 -0700 Received: from [137.202.204.206] (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 18 Sep 2018 11:40:46 +0100 From: Hafiz Abid Qadeer To: "gdb-patches@sourceware.org" Subject: Add '_' in the pattern for reggroup Message-ID: Date: Tue, 18 Sep 2018 11:40:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Hi, I was looking at GDB testcase results for arm-eabi target with qemu, I noticed that register groups returned by the qemu can have '_' in the name e.g. 'cp_regs'. The reggroups.exp fails to recognize that as group name. Fixed by adding '_' in the pattern. OK? gdb/testsuite/ChangeLog: 2018-09-18 Hafiz Abid Qadeer gdb.base/reggroups.exp (fetch_reggroups): Add '_' in match pattern for group name. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/reggroups.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/reggroups.exp b/gdb/testsuite/gdb.base/reggroups.exp index 294f90931f..036c97b844 100644 --- a/gdb/testsuite/gdb.base/reggroups.exp +++ b/gdb/testsuite/gdb.base/reggroups.exp @@ -43,7 +43,7 @@ proc fetch_reggroups {test} { -re "^ Group\[ \t\]+Type\[ \t\]+\r\n" { exp_continue } - -re "^ (\[0-9a-zA-Z-\]+)\[ \t\]+(user|internal)\[ \t\]+\r\n" { + -re "^ (\[_0-9a-zA-Z-\]+)\[ \t\]+(user|internal)\[ \t\]+\r\n" { lappend reggroups $expect_out(1,string) exp_continue }