From patchwork Fri Sep 27 15:07:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 34689 Received: (qmail 58004 invoked by alias); 27 Sep 2019 15:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 57972 invoked by uid 89); 27 Sep 2019 15:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2019 15:07:59 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 02DEFAF5C for ; Fri, 27 Sep 2019 15:07:57 +0000 (UTC) Subject: [committed][gdb/testsuite] Fix incomplete regexps in step-precsave.exp From: Tom de Vries To: gdb-patches@sourceware.org References: <20190927083724.GA30302@delia> Openpgp: preference=signencrypt Message-ID: Date: Fri, 27 Sep 2019 17:07:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190927083724.GA30302@delia> X-IsSubscribed: yes [ was: Re: [committed][gdb/testsuite] Add KFAIL for missing support of reverse-debugging of vmovd ] On 27-09-19 10:37, Tom de Vries wrote: > Hi, > > On my openSUSE Leap 15.1 system I run into: > ... > (gdb) PASS: gdb.reverse/step-precsave.exp: turn on process record > break 76^M > Breakpoint 2 at 0x400654: file step-reverse.c, line 76.^M > (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main > continue^M > Continuing.^M > Process record does not support instruction 0xc5 at address 0x7ffff783fc70.^M > Process record: failed to record execution log.^M > ^M > Program stopped.^M > 0x00007ffff783fc70 in __memset_avx2_unaligned_erms () from /lib64/libc.so.6^M > (gdb) FAIL: gdb.reverse/step-precsave.exp: run to end of main > ... > > The problem is that the vmovd instruction is not supported in > reverse-debugging (PR record/23188). > > Add a KFAIL for this PR. > This fixes an oversight in the previous patch. Thanks, - Tom [gdb/testsuite] Fix incomplete regexps in step-precsave.exp The commit 68f7d34dd50 "[gdb/testsuite] Add KFAIL for missing support of reverse-debugging of vmovd" rewrites a gdb_test into a gdb_test_multiple but forgets to add the $gdb_prompt part in the regexp. Add the missing parts of the regexps. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2019-09-27 Tom de Vries * gdb.reverse/step-precsave.exp: Add missing $gdb_prompt in regexps. --- gdb/testsuite/gdb.reverse/step-precsave.exp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gdb.reverse/step-precsave.exp index f5e15510e1f..2073b8a1542 100644 --- a/gdb/testsuite/gdb.reverse/step-precsave.exp +++ b/gdb/testsuite/gdb.reverse/step-precsave.exp @@ -47,11 +47,13 @@ gdb_test "break $end_of_main" \ # This can take awhile. with_timeout_factor 20 { set test "run to end of main" + set pass_pattern "Breakpoint .* end of main .*" + set kfail_pattern "Process record does not support instruction 0xc5 at.*" gdb_test_multiple "continue" $test { - -re "Breakpoint .* end of main .*" { + -re "\[\r\n\]*(?:$pass_pattern)\[\r\n\]+$gdb_prompt $" { pass $test } - -re "Process record does not support instruction 0xc5 at.*$gdb_prompt $" { + -re "\[\r\n\]*(?:$kfail_pattern)\[\r\n\]+$gdb_prompt $" { kfail "record/23188" $test } }