From patchwork Tue Oct 24 10:09:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 23776 Received: (qmail 123581 invoked by alias); 24 Oct 2017 10:09:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123567 invoked by uid 89); 24 Oct 2017 10:09:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1770, stale X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Oct 2017 10:09:15 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F6708EC; Tue, 24 Oct 2017 10:09:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1F6708EC Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B77C627DF; Tue, 24 Oct 2017 10:09:13 +0000 (UTC) Subject: [PATCH 7/6] More gdb.threads/attach-into-signal.exp stale stopped bits (Re: [PATCH 6/6] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp) To: Yao Qi References: <1508768307-11531-1-git-send-email-palves@redhat.com> <1508768307-11531-7-git-send-email-palves@redhat.com> <86fua957l7.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 24 Oct 2017 11:09:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86fua957l7.fsf@gmail.com> On 10/24/2017 08:27 AM, Yao Qi wrote: > Pedro Alves writes: > >> gdb/testsuite/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry" >> loop. > > Patch is good to me. > Hmmm, noticed a related stale bit further below. Here's a patch that removes it. From 8a645cfef64d4251f34f644792a756959ea440d4 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Mon, 23 Oct 2017 17:46:07 +0100 Subject: [PATCH] More gdb.threads/attach-into-signal.exp stale stopped bits This looks as stale as the other bit that was removed in a previous commit. The test isn't attaching to a stopped process. (And if this were generaly necessary, then it'd be better done from within kill_wait_spawned_process.) gdb/testsuite/ChangeLog: 2017-10-24 Pedro Alves * gdb.threads/attach-into-signal.exp (corefunc): Don't SIGCONT test program before killing it. --- gdb/testsuite/gdb.threads/attach-into-signal.exp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/testsuite/gdb.threads/attach-into-signal.exp b/gdb/testsuite/gdb.threads/attach-into-signal.exp index 3158b59..0af9ed5 100644 --- a/gdb/testsuite/gdb.threads/attach-into-signal.exp +++ b/gdb/testsuite/gdb.threads/attach-into-signal.exp @@ -113,10 +113,6 @@ proc corefunc { threadtype executable } { # Exit and detach the process. gdb_exit - # Continue the program - some Linux kernels need it before -9 if the - # process is stopped. - remote_exec build "kill -s CONT ${testpid}" - kill_wait_spawned_process $test_spawn_id } }