From patchwork Tue Feb 11 21:01:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 37980 Received: (qmail 403 invoked by alias); 11 Feb 2020 21:02:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 375 invoked by uid 89); 11 Feb 2020 21:02:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=H*MI:sk:87a75p9, H*i:sk:87a75p9, H*f:sk:87a75p9 X-HELO: esa4.hgst.iphmx.com Received: from esa4.hgst.iphmx.com (HELO esa4.hgst.iphmx.com) (216.71.154.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 21:02:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1581454920; x=1612990920; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1Dn3LfcK1Afk0jS7GCKAn/YYyT2h9VAgjcuz5qJGJzs=; b=gFug/x75KszVDEeNacOubxS3XrP+8uj+oYLGaXtEULR93efketDeBE/L wf9xMXUpyspLhm6Njtk6+ofCh8mFAqB8goSky0akacajbepnHNl+iSXgf W2WxafpG0gW2gHDqY51hKwci1StD6oAlh/CTq1raJkhx1vNBIF7kqvlU5 OD6FNSFLLsY08N8jLA8h7cVH4u0HWys53H15nfaJFimYpaxV81gB6Va8a HunYX8otdGw7sfTEbukYEQrtLKl8d0VdVIInx37CAvVlqKXWP2aoaxhLH SKH5cbM47HoEY75AFdd22o6sG6IeG7fsHyOpB1NaW9h8RwTY8uOEBXO7O g==; IronPort-SDR: Ysgqonx1dC375bSOPTTMv+uFAaLVY1kJ8JI7JJX52zGOkZZMqsx7r2YML8yI6I2EsIVLe27snW 3yLe3mRrj+yng/glmf2yv7A9A6PUHeerr3XkxFREsIs66562D0jnCQEOEezR9qt1xgz1qfLaFI dRO+hxuKmpvHUepAb/lz/DLxM9n2Jzs93qZVRjFLgKnMn5nnCjKtFKxDq/z6X93TJZplKArZvE oi7f0Y9qATJQ+txQbZ+9y4IJ+kYjOdDUcnF4E8vfvdwQYOq5luLvSQzBKOEisNDs9ZP7CRe1zk 4TU= Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hgst.iphmx.com with ESMTP; 12 Feb 2020 05:01:49 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HTI1oFCbxsiJn0gCtj7SvGORHyRFCkOnyRdNLcjNAopG0Bd4lJc2K7SDGBOPQL/3qkgwqLco59WC1gQUfSg5n7ul+Tyj93G3xbWADkGMCL8OnV+aJZjnBNdEcmlsceIaq4OBfX8OP6oPcdhiV7YdlxLhB6+SWn9pxcKPySvgF9lJjNJaG5fOW15j2eZrjiQnrv5VArRcEtyOWpDVqTlKPxA9DRjDGoazxrr5fSDXvnDHecDezDjYZ6EN9Gx5kWVlU6K8ha1Y7hL42+sz2JNoyb9jni/TDBqByeHJTJi6pgQWvnLYwHf+s7rKCPanr2COkE2Od2Z0loJ5z7K/mkf6WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPepsTvuPnee77VIUCDJ4++rzMExxAgATivQtC4hkJY=; b=YWQfkv36xsTr6/JVgQCoG1Nf11VF+ZXzXizXbMHSIkuEyyqr6UyuBr86glOQJbS57Ap9AlDe7Or1G96NcpFnm/8kTfoydC5JQG2JxASo9eIUROjdxfwRvxdBJOKnxEtMWZq9nJkNa12JtNAuxAxIK17ISuBS26ODTBeAxvVCwBlYTuWIJ300XB9sKGqC31xefAeTbul2Yf9TUkRWR0syz0l1cDUpUZ5riNFf4BcuHF5YZN8K0jSUdvvEHpLd5j8QsPf8SmMvvwQdxVuZLv4+VtllJSy1VHHptUdwfv7yoam/M92UAfrFZ7pakAiMAdpJJ1Qy29wSo5ik4dCu1GMPEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPepsTvuPnee77VIUCDJ4++rzMExxAgATivQtC4hkJY=; b=KlAJqJ6u5R8drUKDEobRgUkRiMpmTaBny8iRukV6b2Rs/BMa2MBq9JP7aJeU7/ZBy0CzFBqwKz2rFzEEPpv9Ac9Io4WesyytWYuuafzG4dwMj0X1G/xFWCsD5cKz+7JaD3SZsIsM8PikGT+Zt1spxffuEsmpqsMZnj2EA9Ps1l4= Received: from MN2PR04MB6095.namprd04.prod.outlook.com (20.178.245.224) by MN2PR04MB6174.namprd04.prod.outlook.com (20.178.249.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Tue, 11 Feb 2020 21:01:48 +0000 Received: from MN2PR04MB6095.namprd04.prod.outlook.com ([fe80::e821:fff9:e1a4:e1bf]) by MN2PR04MB6095.namprd04.prod.outlook.com ([fe80::e821:fff9:e1a4:e1bf%7]) with mapi id 15.20.2707.030; Tue, 11 Feb 2020 21:01:48 +0000 From: "Maciej W. Rozycki" To: Tom Tromey CC: Pedro Alves , "gcc-patches@gcc.gnu.org" , "gdb-patches@sourceware.org" , "binutils@sourceware.org" Subject: Re: [PATCH] configure: Re-disable building cross-gdbserver Date: Tue, 11 Feb 2020 21:01:48 +0000 Message-ID: References: <87a75p9mg9.fsf@tromey.com> In-Reply-To: <87a75p9mg9.fsf@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=macro@wdc.com; wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-messagedata: m9PR2+h2UFfa0pD4jRLuzjnQPh5oIB8Eew5qrYBOd1tzXCLiaCbfK2St+hC2HloBdwrSkSnLLOCA3P6VYdP3eGfjog/XKHK8vcJWvQPjslTKGUchNfjVE4bu4MCunV0G8LKpbhG1lOcBqUJm+OKq8g== x-ms-exchange-transport-forked: True Content-ID: <14D6266A2922144D8B9ACDA25C2303D4@namprd04.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nglBqASZgZDp13vXf9KN/Wmv/UGZxcFxSmIvoQv5YIayqYGFCY+QMtL1rJOQZXHr On Tue, 11 Feb 2020, Tom Tromey wrote: > Maciej> Correct fallout from commit 919adfe84092 ("Move gdbserver to top level") > Maciej> and revert to not building `gdbserver' in a cross-configuration, that is > Maciej> where host != target, matching the documented behaviour. We have no way > Maciej> to support non-native `gdbserver', and native `gdbserver' is usually of > Maciej> no use with cross-GDB of the chosen host. > > Pedro had a different way to do this, that keeps the decision under > gdbserver's control: > > https://sourceware.org/ml/gdb-patches/2020-02/msg00383.html That's actually quite similar to what I considered first, before I changed my mind. Whatever. However I would expect `exit' not to be what we want in a sourced script (I did this differently; see below). > Also note that I haven't sent the top-level configury patches upstream > to gcc yet. I am going to do this all at once, at the end. I think > there's one more patch that will be needed, once gdbserver depends on > the top-level gdbsupport. Ack. Maciej --- gdbserver/configure.srv | 8 ++++++++ 1 file changed, 8 insertions(+) Index: binutils-gdb/gdbserver/configure.srv =================================================================== --- binutils-gdb.orig/gdbserver/configure.srv +++ binutils-gdb/gdbserver/configure.srv @@ -36,6 +36,14 @@ srv_linux_obj="linux-low.o nat/linux-osd # Input is taken from the "${host}" variable. case "${host}" in + ${target}) + gdbserver_host=${host} + ;; + *) + gdbserver_host=NONE + ;; +esac +case "${gdbserver_host}" in aarch64*-*-linux*) srv_tgtobj="linux-aarch64-low.o" srv_tgtobj="$srv_tgtobj nat/aarch64-linux-hw-point.o" srv_tgtobj="$srv_tgtobj linux-aarch32-low.o"