From patchwork Mon Oct 31 16:23:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 17042 Received: (qmail 76963 invoked by alias); 31 Oct 2016 16:23:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 76954 invoked by uid 89); 31 Oct 2016 16:23:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=bus X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Oct 2016 16:23:29 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id AB63BF5647EA8; Mon, 31 Oct 2016 16:23:22 +0000 (GMT) Received: from [10.20.78.238] (10.20.78.238) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 31 Oct 2016 16:23:25 +0000 Date: Mon, 31 Oct 2016 16:23:17 +0000 From: "Maciej W. Rozycki" To: CC: Yao Qi , Pedro Alves Subject: [committed] MIPS: Remove remains of legacy remote target support Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Complement commit f7c382926d78 ("Remove support for "target m32rsdi" and "target mips/pmon/ddb/rockhopper/lsi"") and remove dead MIPS target code which used to support these legacy remote targets. gdb/ * mips-tdep.c (mips_r3041_reg_names): Remove. (mips_breakpoint_from_pc): Remove IDT and PMON breakpoint encodings. --- Regression-tested with the `mips-mti-linux-gnu' target, o32 & n64 ABIs. Committed. NB we also have dead support remains in the test suite, such as gdb/testsuite/config/mips*.exp configuration files and maybe gdb/testsuite/config/vr*.exp qualify as well; there may be more embedded along with generic parts of the framework. Maciej gdb-mips-remote-legacy-remove.diff Index: binutils/gdb/mips-tdep.c =================================================================== --- binutils.orig/gdb/mips-tdep.c 2016-10-28 20:45:06.000000000 +0100 +++ binutils/gdb/mips-tdep.c 2016-10-28 20:47:39.652040455 +0100 @@ -560,19 +560,6 @@ static const char *mips_generic_reg_name "fsr", "fir", }; -/* Names of IDT R3041 registers. */ - -static const char *mips_r3041_reg_names[] = { - "sr", "lo", "hi", "bad", "cause", "pc", - "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", - "f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15", - "f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23", - "f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31", - "fsr", "fir", "", /*"fp" */ "", - "", "", "bus", "ccfg", "", "", "", "", - "", "", "port", "cmp", "", "", "epc", "prid", -}; - /* Names of tx39 registers. */ static const char *mips_tx39_reg_names[NUM_MIPS_PROCESSOR_REGS] = { @@ -7070,23 +7070,10 @@ mips_breakpoint_from_pc (struct gdbarch } else { - /* The IDT board uses an unusual breakpoint value, and - sometimes gets confused when it sees the usual MIPS - breakpoint instruction. */ static gdb_byte big_breakpoint[] = { 0, 0x5, 0, 0xd }; - static gdb_byte pmon_big_breakpoint[] = { 0, 0, 0, 0xd }; - static gdb_byte idt_big_breakpoint[] = { 0, 0, 0x0a, 0xd }; *lenptr = sizeof (big_breakpoint); - - if (strcmp (target_shortname, "mips") == 0) - return idt_big_breakpoint; - else if (strcmp (target_shortname, "ddb") == 0 - || strcmp (target_shortname, "pmon") == 0 - || strcmp (target_shortname, "lsi") == 0) - return pmon_big_breakpoint; - else - return big_breakpoint; + return big_breakpoint; } } else @@ -7116,19 +7103,9 @@ mips_breakpoint_from_pc (struct gdbarch else { static gdb_byte little_breakpoint[] = { 0xd, 0, 0x5, 0 }; - static gdb_byte pmon_little_breakpoint[] = { 0xd, 0, 0, 0 }; - static gdb_byte idt_little_breakpoint[] = { 0xd, 0x0a, 0, 0 }; *lenptr = sizeof (little_breakpoint); - - if (strcmp (target_shortname, "mips") == 0) - return idt_little_breakpoint; - else if (strcmp (target_shortname, "ddb") == 0 - || strcmp (target_shortname, "pmon") == 0 - || strcmp (target_shortname, "lsi") == 0) - return pmon_little_breakpoint; - else - return little_breakpoint; + return little_breakpoint; } } }