[committed] MIPS: Remove remains of legacy remote target support

Message ID alpine.DEB.2.00.1610310104150.31859@tp.orcam.me.uk
State Committed
Headers

Commit Message

Maciej W. Rozycki Oct. 31, 2016, 4:23 p.m. UTC
  Complement commit f7c382926d78 ("Remove support for "target m32rsdi" and 
"target mips/pmon/ddb/rockhopper/lsi"") and remove dead MIPS target code
which used to support these legacy remote targets.

	gdb/
	* mips-tdep.c (mips_r3041_reg_names): Remove.
	(mips_breakpoint_from_pc): Remove IDT and PMON breakpoint 
	encodings.
---
 Regression-tested with the `mips-mti-linux-gnu' target, o32 & n64 ABIs.
Committed.

 NB we also have dead support remains in the test suite, such as 
gdb/testsuite/config/mips*.exp configuration files and maybe 
gdb/testsuite/config/vr*.exp qualify as well; there may be more embedded 
along with generic parts of the framework.

  Maciej

gdb-mips-remote-legacy-remove.diff
  

Patch

Index: binutils/gdb/mips-tdep.c
===================================================================
--- binutils.orig/gdb/mips-tdep.c	2016-10-28 20:45:06.000000000 +0100
+++ binutils/gdb/mips-tdep.c	2016-10-28 20:47:39.652040455 +0100
@@ -560,19 +560,6 @@  static const char *mips_generic_reg_name
   "fsr", "fir",
 };
 
-/* Names of IDT R3041 registers.  */
-
-static const char *mips_r3041_reg_names[] = {
-  "sr", "lo", "hi", "bad", "cause", "pc",
-  "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7",
-  "f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15",
-  "f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23",
-  "f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31",
-  "fsr", "fir", "", /*"fp" */ "",
-  "", "", "bus", "ccfg", "", "", "", "",
-  "", "", "port", "cmp", "", "", "epc", "prid",
-};
-
 /* Names of tx39 registers.  */
 
 static const char *mips_tx39_reg_names[NUM_MIPS_PROCESSOR_REGS] = {
@@ -7070,23 +7070,10 @@  mips_breakpoint_from_pc (struct gdbarch 
 	}
       else
 	{
-	  /* The IDT board uses an unusual breakpoint value, and
-	     sometimes gets confused when it sees the usual MIPS
-	     breakpoint instruction.  */
 	  static gdb_byte big_breakpoint[] = { 0, 0x5, 0, 0xd };
-	  static gdb_byte pmon_big_breakpoint[] = { 0, 0, 0, 0xd };
-	  static gdb_byte idt_big_breakpoint[] = { 0, 0, 0x0a, 0xd };
 
 	  *lenptr = sizeof (big_breakpoint);
-
-	  if (strcmp (target_shortname, "mips") == 0)
-	    return idt_big_breakpoint;
-	  else if (strcmp (target_shortname, "ddb") == 0
-		   || strcmp (target_shortname, "pmon") == 0
-		   || strcmp (target_shortname, "lsi") == 0)
-	    return pmon_big_breakpoint;
-	  else
-	    return big_breakpoint;
+	  return big_breakpoint;
 	}
     }
   else
@@ -7116,19 +7103,9 @@  mips_breakpoint_from_pc (struct gdbarch 
       else
 	{
 	  static gdb_byte little_breakpoint[] = { 0xd, 0, 0x5, 0 };
-	  static gdb_byte pmon_little_breakpoint[] = { 0xd, 0, 0, 0 };
-	  static gdb_byte idt_little_breakpoint[] = { 0xd, 0x0a, 0, 0 };
 
 	  *lenptr = sizeof (little_breakpoint);
-
-	  if (strcmp (target_shortname, "mips") == 0)
-	    return idt_little_breakpoint;
-	  else if (strcmp (target_shortname, "ddb") == 0
-		   || strcmp (target_shortname, "pmon") == 0
-		   || strcmp (target_shortname, "lsi") == 0)
-	    return pmon_little_breakpoint;
-	  else
-	    return little_breakpoint;
+	  return little_breakpoint;
 	}
     }
 }