diff mbox

[committed] testsuite: Fix gdb.base/killed-outside.exp using irrelevant stale options

Message ID alpine.DEB.2.00.1610190509020.31859@tp.orcam.me.uk
State Committed
Headers show

Commit Message

Maciej W. Rozycki Oct. 19, 2016, 5:25 p.m. UTC
Fix a commit 4a556533cf02 ("Fix PR11094: JIT breakpoint is not properly 
recreated on reruns") regression:

Running .../gdb/testsuite/gdb.base/killed-outside.exp ...
Executing on host: mips-mti-linux-gnu-gcc  -Wl,--no-as-needed  -c -g  -o .../gdb/testsuite/outputs/gdb.base/killed-outside/killed-outside0.o .../gdb/testsuite/gdb.base/killed-outside.c .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so    (timeout = 300)
spawn mips-mti-linux-gnu-gcc -Wl,--no-as-needed -c -g -o .../gdb/testsuite/outputs/gdb.base/killed-outside/killed-outside0.o .../gdb/testsuite/gdb.base/killed-outside.c .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so
mips-mti-linux-gnu-gcc: warning: .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so: linker input file unused because linking not done
output is:
mips-mti-linux-gnu-gcc: warning: .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so: linker input file unused because linking not done

gdb compile failed, mips-mti-linux-gnu-gcc: warning: .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so: linker input file unused because linking not done
UNTESTED: gdb.base/killed-outside.exp: failed to prepare

and adjust the call to `prepare_for_testing' by removing a reference to 
`options', which is not set in this test case but a stale value is 
carried over from `gdb.base/jit-simple.exp' previously executed in a 
full test suite run.

	gdb/testsuite/
	* gdb.base/killed-outside.exp: Remove $options from a call to
	`prepare_for_testing'.
---
 Regression-tested with `mips-mti-linux-gnu' and committed as obvious.

  Maciej

gdb-test-killed-outside-options.diff
diff mbox

Patch

Index: binutils/gdb/testsuite/gdb.base/killed-outside.exp
===================================================================
--- binutils.orig/gdb/testsuite/gdb.base/killed-outside.exp	2016-09-29 05:15:13.000000000 +0100
+++ binutils/gdb/testsuite/gdb.base/killed-outside.exp	2016-10-19 05:09:44.618725314 +0100
@@ -80,7 +80,7 @@  proc test {cmds_after_kill} {
     }
 }
 
-if {[prepare_for_testing "failed to prepare" $testfile $srcfile $options] == -1} {
+if {[prepare_for_testing "failed to prepare" $testfile $srcfile] == -1} {
     return -1
 }