From patchwork Thu Oct 6 14:17:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 16304 Received: (qmail 12201 invoked by alias); 6 Oct 2016 14:18:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 12186 invoked by uid 89); 6 Oct 2016 14:18:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=sk:gdb-tes, sk:gdbtes, disconnect, pc X-HELO: mailapp01.imgtec.com Received: from mailapp02.imgtec.com (HELO mailapp01.imgtec.com) (217.156.133.132) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 14:18:05 +0000 Received: from HHMAIL03.hh.imgtec.org (unknown [10.44.0.21]) by Forcepoint Email with ESMTPS id 7ED67D1964867 for ; Thu, 6 Oct 2016 15:17:58 +0100 (IST) Received: from HHMAIL01.hh.imgtec.org (10.100.10.19) by HHMAIL03.hh.imgtec.org (10.44.0.21) with Microsoft SMTP Server (TLS) id 14.3.294.0; Thu, 6 Oct 2016 15:18:01 +0100 Received: from [10.20.78.81] (10.20.78.81) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Thu, 6 Oct 2016 15:18:00 +0100 Date: Thu, 6 Oct 2016 15:17:53 +0100 From: "Maciej W. Rozycki" To: Subject: [committed] testsuite: solib-disc: Use `standard_output_file' Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Correct a commit 2151ccc56c74 ("Always organize test artifacts in a directory hierarchy") regression causing: Running .../gdb/testsuite/gdb.base/solib-disc.exp ... gdb compile failed, Assembler messages: Fatal error: can't create .../gdb/testsuite/gdb.base/so-disc-shr.c.o: No such file or directory by using `standard_output_file' to construct output file names throughout. gdb/testsuite/ * gdb.base/solib-disc.exp: Use `standard_output_file' throughout. --- Tested with `mips-mti-linux-gnu': Running .../gdb/testsuite/gdb.base/solib-disc.exp ... PASS: gdb.base/solib-disc.exp: set stop-on-solib-events 1 PASS: gdb.base/solib-disc.exp: continue to load PASS: gdb.base/solib-disc.exp: save $pc after load PASS: gdb.base/solib-disc.exp: disconnect after load PASS: gdb.base/solib-disc.exp: reconnect after load PASS: gdb.base/solib-disc.exp: check $pc after load PASS: gdb.base/solib-disc.exp: continue to unload PASS: gdb.base/solib-disc.exp: save $pc after unload PASS: gdb.base/solib-disc.exp: disconnect after unload PASS: gdb.base/solib-disc.exp: reconnect after unload PASS: gdb.base/solib-disc.exp: check $pc after unload and committed as obvious. Maciej gdb-test-solib-disc-objfile.diff Index: binutils/gdb/testsuite/gdb.base/solib-disc.exp =================================================================== --- binutils.orig/gdb/testsuite/gdb.base/solib-disc.exp 2016-09-29 05:15:16.000000000 +0100 +++ binutils/gdb/testsuite/gdb.base/solib-disc.exp 2016-10-05 16:38:43.209668731 +0100 @@ -27,11 +27,11 @@ if { [info proc gdb_reconnect] == "" } { set testfile solib-disc set libfile so-disc-shr set srcfile ${testfile}.c -set binfile ${objdir}/${subdir}/${testfile} +set binfile [standard_output_file ${testfile}] set libsrc "${srcdir}/${subdir}/${libfile}.c" set libname "${libfile}.so" -set libobj "${objdir}/${subdir}/${libname}" +set libobj [standard_output_file ${libname}] set execsrc "${srcdir}/${subdir}/${srcfile}" set lib_dlopen [shlib_target_file ${libname}] set lib_syms [shlib_symbol_file ${libname}]