From patchwork Fri Dec 12 14:00:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 4217 Received: (qmail 30079 invoked by alias); 12 Dec 2014 14:00:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 30070 invoked by uid 89); 12 Dec 2014 14:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Dec 2014 14:00:55 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XzQm2-0000kt-Rd from Maciej_Rozycki@mentor.com ; Fri, 12 Dec 2014 06:00:51 -0800 Received: from localhost (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.3.181.6; Fri, 12 Dec 2014 14:00:49 +0000 Date: Fri, 12 Dec 2014 14:00:44 +0000 From: "Maciej W. Rozycki" To: Joel Brobecker , Doug Evans CC: , Rich Fuhler , Richard Sandiford Subject: Re: [PATCH v2 1/2] ISA bit treatment on the MIPS platform In-Reply-To: Message-ID: References: <20120611182043.GA7597@adacore.com> <20141116103721.GG5774@adacore.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Joel, Doug -- On Thu, 4 Dec 2014, Maciej W. Rozycki wrote: > > This is not a requirement for your patch, but if you happen to be able > > to quickly document elf_make_msymbol_special as well, that would be > > a very welcome and appreciated change. > > I have now added these descriptions, with some bias towards the MIPS > specifics as they are what I am most familiar with. Please let me know > if you think they might be further improved. I haven't heard back from you, so I have applied the change now. While reviewing the final ChangeLog entry I discovered I created an unneeded shadow local variable definition, so in addition to the changes already posted in this thread I have included the following cleanup, as obvious, in the final commit. Thanks for your review. Maciej gdb-mips16-isa-bit-cleanup.diff Index: gdb-fsf-trunk-quilt/gdb/dwarf2read.c =================================================================== --- gdb-fsf-trunk-quilt.orig/gdb/dwarf2read.c 2014-12-11 23:54:46.000000000 +0000 +++ gdb-fsf-trunk-quilt/gdb/dwarf2read.c 2014-12-12 00:21:46.768928206 +0000 @@ -7027,9 +7027,6 @@ add_partial_subprogram (struct partial_d CORE_ADDR *lowpc, CORE_ADDR *highpc, int set_addrmap, struct dwarf2_cu *cu) { - struct objfile *objfile = cu->objfile; - struct gdbarch *gdbarch = get_objfile_arch (objfile); - if (pdi->tag == DW_TAG_subprogram) { if (pdi->has_pc_info) @@ -7041,6 +7038,7 @@ add_partial_subprogram (struct partial_d if (set_addrmap) { struct objfile *objfile = cu->objfile; + struct gdbarch *gdbarch = get_objfile_arch (objfile); CORE_ADDR baseaddr; CORE_ADDR highpc; CORE_ADDR lowpc;