CONTRIBUTE: For internals refer to wiki, not gdb/doc

Message ID alpine.DEB.1.10.1409020252590.2958@tp.orcam.me.uk
State Committed
Headers

Commit Message

Maciej W. Rozycki Sept. 2, 2014, 4:30 p.m. UTC
  Hi,

 I've noticed that after this change:

commit 0a7cfe2cf50b450d0cf9db16ee4bd027e08763e8
Author: Stan Shebs <shebs@codesourcery.com>
Date:   Mon Sep 16 18:00:34 2013 +0000

we've now got a stale reference in gdb/CONTRIBUTE to our former internals 
documentation in gdb/doc.  Let's fix it up.  OK to apply?

2014-09-02  Maciej W. Rozycki  <macro@codesourcery.com>

	gdb/
	* CONTRIBUTE (Coding Standards): For internals refer to wiki,
	not gdb/doc.

  Maciej

gdb-contrib-gdbint.diff
  

Comments

Sergio Durigan Junior Sept. 2, 2014, 4:37 p.m. UTC | #1
On Tuesday, September 02 2014, Maciej W. Rozycki wrote:

> Hi,
>
>  I've noticed that after this change:
>
> commit 0a7cfe2cf50b450d0cf9db16ee4bd027e08763e8
> Author: Stan Shebs <shebs@codesourcery.com>
> Date:   Mon Sep 16 18:00:34 2013 +0000
>
> we've now got a stale reference in gdb/CONTRIBUTE to our former internals 
> documentation in gdb/doc.  Let's fix it up.  OK to apply?

IMO this falls under the OBVIOUS rule :-).  I'm not a maintainer,
though.

Thanks,
  
Maciej W. Rozycki Sept. 2, 2014, 5:11 p.m. UTC | #2
On Tue, 2 Sep 2014, Sergio Durigan Junior wrote:

> > we've now got a stale reference in gdb/CONTRIBUTE to our former internals 
> > documentation in gdb/doc.  Let's fix it up.  OK to apply?
> 
> IMO this falls under the OBVIOUS rule :-).  I'm not a maintainer,
> though.

 Maybe, though I'd rather see someone who has worked on stuff in this area 
have a look at it.  Perhaps there's a better URL to use or suchlike.

  Maciej
  
Maciej W. Rozycki Sept. 9, 2014, 4:49 p.m. UTC | #3
On Tue, 2 Sep 2014, Maciej W. Rozycki wrote:

> On Tue, 2 Sep 2014, Sergio Durigan Junior wrote:
> 
> > > we've now got a stale reference in gdb/CONTRIBUTE to our former internals 
> > > documentation in gdb/doc.  Let's fix it up.  OK to apply?
> > 
> > IMO this falls under the OBVIOUS rule :-).  I'm not a maintainer,
> > though.
> 
>  Maybe, though I'd rather see someone who has worked on stuff in this area 
> have a look at it.  Perhaps there's a better URL to use or suchlike.

 Ping?  Or I'll push it as it is next week.

  Maciej
  
Maciej W. Rozycki Sept. 16, 2014, 10:49 p.m. UTC | #4
On Tue, 9 Sep 2014, Maciej W. Rozycki wrote:

> > > > we've now got a stale reference in gdb/CONTRIBUTE to our former internals 
> > > > documentation in gdb/doc.  Let's fix it up.  OK to apply?
> > > 
> > > IMO this falls under the OBVIOUS rule :-).  I'm not a maintainer,
> > > though.
> > 
> >  Maybe, though I'd rather see someone who has worked on stuff in this area 
> > have a look at it.  Perhaps there's a better URL to use or suchlike.
> 
>  Ping?  Or I'll push it as it is next week.

 Pushed thus.

  Maciej
  

Patch

Index: gdb-fsf-trunk-quilt/gdb/CONTRIBUTE
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/CONTRIBUTE	2013-10-26 20:23:01.000000000 +0100
+++ gdb-fsf-trunk-quilt/gdb/CONTRIBUTE	2014-09-01 17:58:42.068940061 +0100
@@ -32,11 +32,12 @@  o	Coding Standards
 	Submissions which do not conform to the standards will be
 	returned with a request to reformat the changes.
 
+	Ref: http://www.gnu.org/prep/standards_toc.html
+
 	GDB has certain additional coding requirements.  Those
-	requirements are explained in the GDB internals documentation
-	in the gdb/doc directory.
+	requirements are explained in the GDB internals documentation.
 
-	Ref: http://www.gnu.org/prep/standards_toc.html
+	Ref: http://sourceware.org/gdb/wiki/Internals%20Coding-Standards
 
 
 o	Copyright Assignment