From patchwork Wed Oct 24 19:35:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 29877 Received: (qmail 119130 invoked by alias); 24 Oct 2018 19:34:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119114 invoked by uid 89); 24 Oct 2018 19:34:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=learn X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 19:34:57 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 74E44AEE5; Wed, 24 Oct 2018 19:34:55 +0000 (UTC) Subject: Re: [OB PATCH][gdb/testsuite] Handle removed valgrind option --db-attach To: Pedro Alves , gdb-patches@sourceware.org, Philippe Waroquiers References: <20181024111355.GA13788@delia> <961cdab7-7882-6795-fac3-561db78d6593@redhat.com> From: Tom de Vries Message-ID: Date: Wed, 24 Oct 2018 21:35:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <961cdab7-7882-6795-fac3-561db78d6593@redhat.com> X-IsSubscribed: yes On 10/24/18 6:29 PM, Pedro Alves wrote: > On 10/24/2018 12:13 PM, Tom de Vries wrote: >> Hi, >> >> When running valgrind-db-attach.exp with valgrind version 3.13.0, we get: >> ... >> PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind >> valgrind: Unknown option: --db-attach=yes >> valgrind: Use --help for more information or consult the user manual. >> ERROR: Process no longer exists >> UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started >> ... >> >> The valgrind option --db-attach has been deprecated in version 3.10.0, and >> removed in version 3.11.0. >> > > But was it replaced with / renamed to something else equivalent, > or the functionality completely eliminated? > From http://valgrind.org/docs/manual/dist.news.html: ... * ================== DEPRECATED FEATURES ================= * --db-attach is now deprecated and will be removed in the next valgrind feature release. The built-in GDB server capabilities are superior and should be used instead. Learn more here: http://valgrind.org/docs/manual/manual-core-adv.html#manual-core-adv.gdbserver ... I'd say the functionality was replaced with vgdb, which is exercised in other test-cases (valgrind-infcall.exp, valgrind-disp-step.exp). > If the latter, I don't see much value in keeping the > test case around going forward. Especially if we have no > comment in the source indicating when it stopped being useful... I could add this (similar to the "valgrind is not >= 3.7.0" comment in valgrind-infcall.exp): ... ... ? > It ends up just being dead weight and future gdb developers > won't even realize. > True. I can also remove the testcase. Thanks, - Tom diff --git a/gdb/testsuite/gdb.base/valgrind-db-attach.exp b/gdb/testsuite/gdb.base/valgrind-db-attach.exp index 3e40283a95..dd13b4d170 100644 --- a/gdb/testsuite/gdb.base/valgrind-db-attach.exp +++ b/gdb/testsuite/gdb.base/valgrind-db-attach.exp @@ -52,6 +52,7 @@ set test "valgrind started" # The trailing '.' differs for different memcheck versions. gdb_test_multiple "" $test { -re "valgrind: Unknown option: --db-attach=yes" { + # valgrind is not <= 3.10.0. unsupported $test return -1 }