Add an objfile getter to gdb.Type

Message ID	a6f6388c-3d0e-55cc-be02-9345c36237d8@redhat.com
State	New, archived
Headers	Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk Sender: gdb-patches-owner@sourceware.org Subject: Re: [PATCH] Add an objfile getter to gdb.Type To: Tom Tromey <tom@tromey.com>, Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> References: <20190523203227.260432-1-cbiesinger@google.com> <20190523213729.27928-1-cbiesinger@google.com> <87k1ea5j2i.fsf@tromey.com> <CAPTJ0XHdJd4duf5zk2Uat0ZkeiV67Xuh0g66wT6grW9N5A3RDA@mail.gmail.com> <87muiyla77.fsf@tromey.com> <CAPTJ0XFgYXaLtUyeNA6jiyjC-mDt3kSpG3=BPO702c8hXC2xtw@mail.gmail.com> <87d0jtl5dm.fsf@tromey.com> Cc: Christian Biesinger <cbiesinger@google.com> From: Pedro Alves <palves@redhat.com> Message-ID: <a6f6388c-3d0e-55cc-be02-9345c36237d8@redhat.com> Date: Tue, 4 Jun 2019 22:48:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87d0jtl5dm.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit

Message ID

a6f6388c-3d0e-55cc-be02-9345c36237d8@redhat.com

State

New, archived

Headers

Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
Sender: gdb-patches-owner@sourceware.org
Subject: Re: [PATCH] Add an objfile getter to gdb.Type
To: Tom Tromey <tom@tromey.com>,
	Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
References: <20190523203227.260432-1-cbiesinger@google.com>
	<20190523213729.27928-1-cbiesinger@google.com>
	<87k1ea5j2i.fsf@tromey.com>
	<CAPTJ0XHdJd4duf5zk2Uat0ZkeiV67Xuh0g66wT6grW9N5A3RDA@mail.gmail.com>
	<87muiyla77.fsf@tromey.com>
	<CAPTJ0XFgYXaLtUyeNA6jiyjC-mDt3kSpG3=BPO702c8hXC2xtw@mail.gmail.com>
	<87d0jtl5dm.fsf@tromey.com>
Cc: Christian Biesinger <cbiesinger@google.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <a6f6388c-3d0e-55cc-be02-9345c36237d8@redhat.com>
Date: Tue, 4 Jun 2019 22:48:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <87d0jtl5dm.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Commit Message

Pedro Alves June 4, 2019, 9:48 p.m. UTC

  On 6/4/19 4:47 PM, Tom Tromey wrote:
>>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Christian> I don't think I'll be writing enough patches for that to be worth it,
> Christian> so it would be great if you could commit this. Thanks!
> 
> I checked it in.

FYI, I pushed in these fixes to the ChangeLog files.

Christian, the issue here is that entry paths are relative to the
corresponding ChangeLog file.

From d3238f7d90715dad7e8da2a8c2486d26124b0c84 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Tue, 4 Jun 2019 22:44:36 +0100
Subject: [PATCH] Fix paths to ChangeLog files

---
 gdb/ChangeLog           | 4 ++--
 gdb/doc/ChangeLog       | 2 +-
 gdb/testsuite/ChangeLog | 3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

Comments

Terekhov, Mikhail via Gdb-patches June 4, 2019, 10:06 p.m. UTC | #1

On Tue, Jun 4, 2019 at 4:48 PM Pedro Alves <palves@redhat.com> wrote:
>
> On 6/4/19 4:47 PM, Tom Tromey wrote:
> >>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
> >
> > Christian> I don't think I'll be writing enough patches for that to be worth it,
> > Christian> so it would be great if you could commit this. Thanks!
> >
> > I checked it in.
>
> FYI, I pushed in these fixes to the ChangeLog files.
>
> Christian, the issue here is that entry paths are relative to the
> corresponding ChangeLog file.

Oh, sorry about that! Thanks for fixing!

Christian

Tom Tromey June 5, 2019, 1:51 a.m. UTC | #2

>>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:

>> Christian, the issue here is that entry paths are relative to the
>> corresponding ChangeLog file.

Christian> Oh, sorry about that! Thanks for fixing!

Oops on me too, I should have read more closely.

Tom

diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 933f23249ff..e36eae9ac16 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,8 +1,8 @@ 
 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 
 	Add objfile property to gdb.Type.
-	* gdb/NEWS: Mention Python API addition.
-	* gdb/python/py-type.c (typy_get_objfile): New method.
+	* NEWS: Mention Python API addition.
+	* python/py-type.c (typy_get_objfile): New method.
 
 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index ea98096845a..5da25996b1c 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,6 +1,6 @@ 
 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 
-	* gdb/doc/python.texi: Document new gdb.Type.objfile property.
+	* python.texi: Document new gdb.Type.objfile property.
 
 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index af451fa4e12..722249f822c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,7 +1,6 @@ 
 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 
-	* gdb/testsuite/gdb.python/py-type.exp: Test for new
-	  gdb.Type.objfile property.
+	* gdb.python/py-type.exp: Test for new gdb.Type.objfile property.
 
 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>