From patchwork Mon Oct 14 15:23:28 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Tom de Vries <tdevries@suse.de>
X-Patchwork-Id: 34940
Received: (qmail 77871 invoked by alias); 14 Oct 2019 15:23:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 77860 invoked by uid 89); 14 Oct 2019 15:23:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00,
	GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
	SPF_PASS autolearn=ham version=3.3.1 spammy=14-10-2019,
	HX-Languages-Length:1465
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by
	sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;
	Mon, 14 Oct 2019 15:23:31 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx1.suse.de
	(Postfix) with ESMTP id 1AF7EBA73;
	Mon, 14 Oct 2019 15:23:29 +0000 (UTC)
Subject: Re: [gdb/tdep] Fix 'Unexpected register class' assert in
	amd64_push_arguments
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: Pedro Alves <palves@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	nd <nd@arm.com>
References: <20190116155734.53824-1-alan.hayward@arm.com>
	<20190116155734.53824-2-alan.hayward@arm.com>
	<386a4a7f-f7df-e1da-42b8-b0724e1e36b2@redhat.com>
	<5255A57D-0F2C-4A3B-816A-6F46C0B0C2B1@arm.com>
	<018D8C19-1A45-4012-BAC6-90ACDA074740@arm.com>
	<ce7d934a-4305-b28c-655d-1c545ffbfdcb@suse.de>
	<e978dc7f-d555-e4fc-72d4-2fa5c9aef41b@suse.de>
	<6CC13BF5-B6E5-45F5-ACD9-86DA31054E52@arm.com>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <a298aaa0-5809-bf56-955c-67fe9a7bd0d6@suse.de>
Date: Mon, 14 Oct 2019 17:23:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:68.0) Gecko/20100101 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <6CC13BF5-B6E5-45F5-ACD9-86DA31054E52@arm.com>
X-IsSubscribed: yes

On 14-10-2019 15:10, Alan Hayward wrote:
>> This exposes 9 more FAILs of the PR tdep/25096 type, so mark all 12 of them as
>> KFAIL.
> When I run the test, I get three unexpected passes:
> 
> 
> # of expected passes		9388
> # of unknown successes		3
> # of known failures		9
> 
> KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-tc-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096)
> KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-ts-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096)
> KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-ti-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096)

That could be due to registers happening to have the correct value.

Do these turn into KFAILs if you add:
...
...
?

Thanks,
- Tom

diff --git a/gdb/testsuite/gdb.base/infcall-nested-structs.exp
b/gdb/testsuite/gdb.base/infcall-nested-structs.
exp
index 957eb31bdc2..f62f636aa11 100644
--- a/gdb/testsuite/gdb.base/infcall-nested-structs.exp
+++ b/gdb/testsuite/gdb.base/infcall-nested-structs.exp
@@ -134,6 +134,7 @@ proc run_tests { lang types } {

        if { $lang == "c++" && $name == "struct_02_01"
             && [regexp "^types-(tf-t(c|s|i)|t(c|s|i)-tf)" $types match] } {
+           gdb_test_no_output "set \$xmm0.v2_int64\[0\] = 0"
            setup_kfail gdb/25096 "x86_64-*-linux*"
        }
        gdb_test "p/d check_arg_${name} (ref_val_${name})" "= 1"