From patchwork Tue Apr 4 10:14:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19816 Received: (qmail 48776 invoked by alias); 4 Apr 2017 10:14:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 48747 invoked by uid 89); 4 Apr 2017 10:14:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0087.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 10:14:31 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0102.eurprd08.prod.outlook.com (10.160.211.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Tue, 4 Apr 2017 10:14:30 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d%16]) with mapi id 15.01.1005.018; Tue, 4 Apr 2017 10:14:30 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: [PATCH 7/11] Add BFIN_MAX_REGISTER_SIZE Date: Tue, 4 Apr 2017 10:14:30 +0000 Message-ID: authentication-results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0102; 7:lNErlHbHKT2oLabttvmIrb2ZcmUrzVFwCW4owRNO/fOTbHTBDX4f0yEgoW2oasbFNvvOwIpaijmUTOb7ifWvdhwtCyJmPcJo064CHNTuYpbkNX7JWs6W/q/obXK59kuebuxnQQK0f17ht3cy4JlDSl4VbbDx1zP675aj/vt/nqZZUOyF37MPa/RDn9zOfs94RbOZKF6vSxCBzoKdhhgyOb/UQozJOXYFROsLudZns29LwHFZpDrPiVS2nnP+AM68/cfErYnEqWBLp898ZI1t9p/HCh8HWkTZUavIqNQvP36f1/TX2RBEO87CB9x93RxZ2PJuj7AwJu7P+A6WvAIAHw==; 20:u1+4va55V5AR7oQJnEMD8CoLiHXlIT6aGXetqNI0HBH6FMYWXSVPGWrMWvMn1iW27zZAtDECcF9VupY857FeKtnTJF0e2jBgd9AIXpH/b4ahhN5nURVNe9zmHB83Z9mA7Er2lf9cleHX0ZAjavjJNRM6bAcLVIAIE7hXB/NPe7I= x-ms-office365-filtering-correlation-id: 44c673aa-629e-4f9e-b487-08d47b4361e6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:AM3PR08MB0102; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:AM3PR08MB0102; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0102; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39450400003)(39850400002)(39400400002)(39840400002)(377424004)(8936002)(2351001)(4326008)(81166006)(8676002)(25786009)(6916009)(5250100002)(575784001)(2906002)(86362001)(50986999)(33656002)(2900100001)(54356999)(189998001)(3660700001)(3846002)(110136004)(38730400002)(6486002)(83716003)(6506006)(66066001)(36756003)(7736002)(99286003)(5660300001)(5640700003)(82746002)(6436002)(53936002)(6116002)(305945005)(3280700002)(6512007)(102836003)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0102; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2017 10:14:30.0426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0102 Max size set to 32bits, which I determined using regformats/reg-bfin.dat Tested on a --enable-targets=all build using make check with board files unix and native-gdbserver. I do not have an BFIN machine to test on. Ok to commit? Alan. 2017-04-04 Alan Hayward * bfin-tdep.c (bfin_pseudo_register_read): Use BFIN_MAX_REGISTER_SIZE. (bfin_pseudo_register_write): Likewise. * bfin-tdep.h (BFIN_MAX_REGISTER_SIZE): Add. diff --git a/gdb/bfin-tdep.h b/gdb/bfin-tdep.h index 164466c2d6d1bd2dc0bc47ca3729d0e42e2d7ccb..e89e5c3138eb8245b10ccda98f0672e8e3fd728b 100644 --- a/gdb/bfin-tdep.h +++ b/gdb/bfin-tdep.h @@ -84,6 +84,9 @@ enum gdb_regnum { #define BFIN_NUM_REGS (BFIN_PC_REGNUM + 1) #define BFIN_NUM_PSEUDO_REGS (1) +/* Big enough to hold the size of the largest register in bytes. */ +#define BFIN_MAX_REGISTER_SIZE 4 + /* The ABIs for Blackfin. */ enum bfin_abi { diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c index 3df1ba387a323dc6827b1189432f8877d1833184..9b45633cab15b8e0adb0d51a2fa650dc2bc6339b 100644 --- a/gdb/bfin-tdep.c +++ b/gdb/bfin-tdep.c @@ -689,7 +689,7 @@ static enum register_status bfin_pseudo_register_read (struct gdbarch *gdbarch, struct regcache *regcache, int regnum, gdb_byte *buffer) { - gdb_byte *buf = (gdb_byte *) alloca (MAX_REGISTER_SIZE); + gdb_byte *buf = (gdb_byte *) alloca (BFIN_MAX_REGISTER_SIZE); enum register_status status; if (regnum != BFIN_CC_REGNUM) @@ -710,7 +710,7 @@ static void bfin_pseudo_register_write (struct gdbarch *gdbarch, struct regcache *regcache, int regnum, const gdb_byte *buffer) { - gdb_byte *buf = (gdb_byte *) alloca (MAX_REGISTER_SIZE); + gdb_byte *buf = (gdb_byte *) alloca (BFIN_MAX_REGISTER_SIZE); if (regnum != BFIN_CC_REGNUM) internal_error (__FILE__, __LINE__,