From patchwork Mon Mar 30 17:20:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 5916 Received: (qmail 20946 invoked by alias); 30 Mar 2015 17:20:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20922 invoked by uid 89); 30 Mar 2015 17:20:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KAM_FROM_URIBL_PCCC, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ob0-f174.google.com Received: from mail-ob0-f174.google.com (HELO mail-ob0-f174.google.com) (209.85.214.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 30 Mar 2015 17:20:34 +0000 Received: by obvd1 with SMTP id d1so65182480obv.0; Mon, 30 Mar 2015 10:20:32 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.210.197 with SMTP id mw5mr28200090obc.26.1427736027779; Mon, 30 Mar 2015 10:20:27 -0700 (PDT) Received: by 10.76.134.102 with HTTP; Mon, 30 Mar 2015 10:20:27 -0700 (PDT) In-Reply-To: References: <1427730751.30498.4.camel@ubuntu-sellcey> Date: Mon, 30 Mar 2015 10:20:27 -0700 Message-ID: Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd From: "H.J. Lu" To: sellcey@imgtec.com Cc: Binutils , GDB X-IsSubscribed: yes On Mon, Mar 30, 2015 at 9:31 AM, H.J. Lu wrote: > On Mon, Mar 30, 2015 at 8:52 AM, Steve Ellcey wrote: >> On Sun, 2015-03-29 at 07:10 -0700, H.J. Lu wrote: >>> On Thu, Mar 26, 2015 at 8:57 AM, H.J. Lu wrote: >>> > I imported zlib from GCC. This patch adds --with-system-zlib and remove >>> > --with-zlib in bfd. OK for master? >> >> I think the global binutils-gdb Makefile needs to have a dependency of >> bfd on zlib. If I build 'all-binutils' (using just the binutils-gdb >> repository, not a combined tree with GCC) I get a build failure. If I >> explicitly build all-zlib before building all-binutils it works, but I >> should not have to do that. >> >> >> /bin/sh ./libtool --tag=CC --mode=link gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -I/scratch/sellcey/repos/nightly/src/binutils-gdb/bfd/../zlib -g -O2 -rpath /scratch/sellcey/repos/nightly/install-mips-mti-linux-gnu/x86_64-unknown-linux-gnu/mips-mti-linux-gnu/lib -release `cat libtool-soversion` -static-libstdc++ -static-libgcc -o libbfd.la archive.lo archures.lo bfd.lo bfdio.lo bfdwin.lo cache.lo coff-bfd.lo compress.lo corefile.lo format.lo hash.lo init.lo libbfd.lo linker.lo merge.lo opncls.lo reloc.lo section.lo simple.lo stab-syms.lo stabs.lo syms.lo targets.lo binary.lo ihex.lo srec.lo tekhex.lo verilog.lo `cat ofiles` -ldl -L../zlib -lz -ldl >> ./libtool: line 5195: cd: ../zlib: No such file or directory >> libtool: link: cannot determine absolute directory name of `../zlib' >> make[3]: *** [libbfd.la] Error 1 >> make[3]: Leaving directory `/scratch/sellcey/repos/nightly/obj-mips-mti-linux-gnu/binutils-gdb/bfd' >> make[2]: *** [all-recursive] Error 1 >> make[2]: Leaving directory `/scratch/sellcey/repos/nightly/obj-mips-mti-linux-gnu/binutils-gdb/bfd' >> make[1]: *** [all] Error 2 >> make[1]: Leaving directory `/scratch/sellcey/repos/nightly/obj-mips-mti-linux-gnu/binutils-gdb/bfd' >> make: *** [all-bfd] Error 2 >> Error: Make command failed, stopping build. > > I will take a look. > This is the patch I checked in. diff --git a/ChangeLog b/ChangeLog index ad04e40..4110c29 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2015-03-30 H.J. Lu + + * Makefile.def (dependencies): Add all-zlib to all-bfd. + * Makefile.in: Regenerated. + 2015-03-28 H.J. Lu * src-release.sh (do_proto_toplev): Configure with --target diff --git a/Makefile.def b/Makefile.def index e0ea2fb..4e76450 100644 --- a/Makefile.def +++ b/Makefile.def @@ -402,6 +402,7 @@ dependencies = { module=configure-bfd; on=configure-libiberty; hard=true; }; dependencies = { module=configure-bfd; on=configure-intl; }; dependencies = { module=all-bfd; on=all-libiberty; }; dependencies = { module=all-bfd; on=all-intl; }; +dependencies = { module=all-bfd; on=all-zlib; }; dependencies = { module=configure-opcodes; on=configure-libiberty; hard=true; }; dependencies = { module=all-opcodes; on=all-libiberty; }; diff --git a/Makefile.in b/Makefile.in index 6f9dfd4..cc05f7b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -49969,6 +49969,14 @@ all-stage3-bfd: maybe-all-stage3-intl all-stage4-bfd: maybe-all-stage4-intl all-stageprofile-bfd: maybe-all-stageprofile-intl all-stagefeedback-bfd: maybe-all-stagefeedback-intl +all-bfd: maybe-all-zlib + +all-stage1-bfd: maybe-all-stage1-zlib +all-stage2-bfd: maybe-all-stage2-zlib +all-stage3-bfd: maybe-all-stage3-zlib +all-stage4-bfd: maybe-all-stage4-zlib +all-stageprofile-bfd: maybe-all-stageprofile-zlib +all-stagefeedback-bfd: maybe-all-stagefeedback-zlib configure-opcodes: configure-libiberty configure-stage1-opcodes: configure-stage1-libiberty