From patchwork Thu Aug 30 18:34:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?15nXoten15Eg16nXnteX15XXoNeZ?= X-Patchwork-Id: 29137 Received: (qmail 52770 invoked by alias); 30 Aug 2018 18:34:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 52756 invoked by uid 89); 30 Aug 2018 18:34:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, FROM_EXCESS_BASE64, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-DKIM-Signature:6vw, H*c:alternative X-HELO: mail-ed1-f52.google.com Received: from mail-ed1-f52.google.com (HELO mail-ed1-f52.google.com) (209.85.208.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Aug 2018 18:34:48 +0000 Received: by mail-ed1-f52.google.com with SMTP id h9-v6so7267672edr.0 for ; Thu, 30 Aug 2018 11:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=fQw34YnRHgr3vKisApWGU0vDVK/GmlTHC4XbOdq9nnc=; b=tgxFtRYy+4HzHiNCxLUUqvA1M7x6W7wu2nO8GLAnJnoK1DQNdpSzPrzcCJzkg5y5fd rCEzrWoQyGwYQrRodDvuFaLTfCCHiKHuhxOXDo62OgqXxiShhS7CZgXAM7IC5tQN8Jhe j3w5I41NINInNFNRVnQvWcW4qg7ko9OisfboCw0j+2+IMDuhdFdJzha1vSspb/9isT7e TJvSmswhHyidv04Zbjf2yBxKYrA57zH/n54hco+nF4rwOxZ7Cwxb2i6JAbgQcAIsH6cf aPo+aTScLVMfe7Ag5BkELFyvcEwSNiWwPq8SePJAYpZI3uvcKeeQfSIYfcnoPQSaClIw hOGQ== MIME-Version: 1.0 From: =?UTF-8?B?15nXoten15Eg16nXnteX15XXoNeZ?= Date: Thu, 30 Aug 2018 21:34:45 +0300 Message-ID: Subject: src/gdb/breakpoint.c:3092: redundant test ? To: gdb-patches@sourceware.org 2018-08-30 Yacov Simhony * breakpoint.c (update_inserted_breakpoint_locations): remove reduandant condition diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 4e7dac5..3a9b712 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -2898,7 +2898,7 @@ update_inserted_breakpoint_locations (void) /* We only want to update locations that are already inserted and need updating. This is to avoid unwanted insertion during deletion of breakpoints. */ - if (!bl->inserted || (bl->inserted && !bl->needs_update)) + if (!bl->inserted || !bl->needs_update) continue; switch_to_program_space_and_thread (bl->pspace);