From patchwork Fri Nov 7 13:49:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Chandra Reddy X-Patchwork-Id: 3609 Received: (qmail 13438 invoked by alias); 7 Nov 2014 13:49:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 13343 invoked by uid 89); 7 Nov 2014 13:49:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f176.google.com Received: from mail-ob0-f176.google.com (HELO mail-ob0-f176.google.com) (209.85.214.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 07 Nov 2014 13:49:23 +0000 Received: by mail-ob0-f176.google.com with SMTP id va2so2544303obc.21 for ; Fri, 07 Nov 2014 05:49:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=kbpAuG9uoEYganpTkEj0pCVtZ0GQjJ115yv01RNgwLo=; b=TqUvT+5P/Kf5SCcsz0+DQinuA+QhKb0T6QiPrqJ6I54POR0GFco5NHLeiIgEzQ7QKj VigJttSeVzHt65SaEeu9ksdfemKkjJA7nVJ5Jey5KVM2f/wjNWhfO2WwkPRbkt49Nal1 A/Xxc4Dbjl4SzqThP3JrtWR98C4tczWkZygZZXbw+7NsxmKoE4xkVNmMskYGYh5FBphG FCO7KZVn00AnoMLtJEmhZQU1AlZFT3dpFSOgGExKzW3xMHfaKvehOK1yVzgsD/xuA5a4 /cDtC3bg3EpBX4Lem1LW50WpiVcwbQu/0+twLITYicEt5JkiCHGBf0jIjqvPxI2mxK8i SKQg== X-Gm-Message-State: ALoCoQnYhbmc8onh7OF6vNGVb1NPxGDZLSgCkgU3bIp8P9W55TeDxYhL9T6OmIcLneiq572G9B1n MIME-Version: 1.0 X-Received: by 10.202.222.9 with SMTP id v9mr549259oig.112.1415368161252; Fri, 07 Nov 2014 05:49:21 -0800 (PST) Received: by 10.202.137.1 with HTTP; Fri, 7 Nov 2014 05:49:21 -0800 (PST) In-Reply-To: References: Date: Fri, 7 Nov 2014 05:49:21 -0800 Message-ID: Subject: Re: [PATCH] Remove unwanted spaces when looking up builtin types From: Siva Chandra To: gdb-patches X-IsSubscribed: yes On Wed, Oct 29, 2014 at 11:50 AM, Siva Chandra wrote: > Currently, if we do something like gdb.lookup_type(" unsigned long "), > GDB errors out because of the leading and trailing spaces. The > attached patch fixes this problem. > > A practical situation where this problem is hit is when invoking > template methods. Its not uncommon to do things like this: > > (gdb) p foo.bar< unsigned long >() > > If "bar" happens to be an xmethod, then its implementation will > typically need to parse the name of the method ("bar< unsigned long >" > in the above example) to get the template argument and lookup the > type. GDB currently fails for such cases. One could of course > sanitize/fix such inputs in Python before calling lookup_type, but I > think it is better done on the GDB side as having white spaces is > valid syntax. > > For non-builtin types, lookup_type goes through the symbol lookup > path. AFAIU, that path already ignores whitespaces. Ping. gdb/ChangeLog: 2014-11-07 Siva Chandra Reddy * language.c (language_lookup_primitive_type_by_name): Remove unwanted space in the type name before looking it up. (whitespace_p): New function. gdb/testsuite/ChangeLog: 2014-11-07 Siva Chandra Reddy * gdb.python/py-type.exp: Add new tests. diff --git a/gdb/language.c b/gdb/language.c index 034086d..abfed40 100644 --- a/gdb/language.c +++ b/gdb/language.c @@ -981,6 +981,17 @@ language_bool_type (const struct language_defn *la, return ld->arch_info[la->la_language].bool_type_default; } +/* Return 1 if C is a whitespace character, 0 otherwise. */ + +static int +whitespace_p (const char c) +{ + if (c == ' ' || c == '\n' || c == '\t') + return 1; + else + return 0; +} + struct type * language_lookup_primitive_type_by_name (const struct language_defn *la, struct gdbarch *gdbarch, @@ -989,14 +1000,44 @@ language_lookup_primitive_type_by_name (const struct language_defn *la, struct language_gdbarch *ld = gdbarch_data (gdbarch, language_gdbarch_data); struct type *const *p; + int len = strlen (name); + int i, j; + char *clean_name = (char *) xmalloc (sizeof (char) * len + 1); + + /* Remove unwanted whitespace in the typename. This could happen, for + example, happen if one does gdb.lookup_type(' unsigned long ') in + Python. */ + for (i = 0, j = 0; i < len; i++) + { + if (whitespace_p (name[i])) + { + if (j == 0 || clean_name[j - 1] == ' ') + continue; + } + + if (whitespace_p (name[i])) + clean_name[j] = ' '; + else + clean_name[j] = name[i]; + + j++; + } + if (j > 0 && clean_name[j - 1] == ' ') + j--; + clean_name[j] = '\0'; for (p = ld->arch_info[la->la_language].primitive_type_vector; (*p) != NULL; p++) { - if (strcmp (TYPE_NAME (*p), name) == 0) - return (*p); + if (strcmp (TYPE_NAME (*p), clean_name) == 0) + { + xfree (clean_name); + return (*p); + } } + xfree (clean_name); + return (NULL); } diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp index 6b61f48..c9388ed 100644 --- a/gdb/testsuite/gdb.python/py-type.exp +++ b/gdb/testsuite/gdb.python/py-type.exp @@ -264,3 +264,15 @@ with_test_prefix "lang_cpp" { test_template test_enums } + +# Tests to lookup builtin types +gdb_test "python print gdb.lookup_type ('unsigned int')" "unsigned int" \ + "lookup unsigned int" +gdb_test "python print gdb.lookup_type (' unsigned long ')" "unsigned long" \ + "lookup unsigned long" +gdb_test "python print gdb.lookup_type (' unsigned char ')" "unsigned char" \ + "lookup unsigned char" +gdb_test "python print gdb.lookup_type (' unsigned\\n char ')" "unsigned char" \ + "lookup unsigned char" +gdb_test "python print gdb.lookup_type (' unsigned\\tlong ')" "unsigned long" \ + "lookup unsigned long"