From patchwork Wed Apr 2 20:46:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Chandra Reddy X-Patchwork-Id: 391 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id 851073600A2 for ; Wed, 2 Apr 2014 13:47:10 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id 19C8AFD167A; Wed, 2 Apr 2014 13:47:10 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id E19F1FD1676 for ; Wed, 2 Apr 2014 13:47:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:date:message-id:subject:from:to :content-type; q=dns; s=default; b=tHxzv3v5y+wkpc0xCj/IjfFeQ877N Mx3Sty5k158jyIwRlJ/vB3dlmrQqfxnuB2hntUYqGHO54PETsQdwC8alzINhrrqM uyeteZDzyVkLoxIGwPWk2YYx8E00fgdyTyqnnTMetLclMYqKRDRxV+E2nUipMXLq R7BDC0wwSxkxGs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:date:message-id:subject:from:to :content-type; s=default; bh=B+X29hPZxvUAZPo+jbnOxxJQ/Ss=; b=yJe abb+QGD0Nv1Nqn88fVew+swuvUPkgWZvEsy7UoLScuS07S8aIs52Vyolo+Lv266n ixM4yJeKO1s0OyS8vWIQ74j2P//cDLK4gWeNkUMyMTFq3WANwKhw8HFW3RHNd7qq xTecoVZesRH7uWIML0JjjisY7RTqf/XeMeU2X0BI= Received: (qmail 30198 invoked by alias); 2 Apr 2014 20:47:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 30187 invoked by uid 89); 2 Apr 2014 20:47:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f174.google.com Received: from mail-we0-f174.google.com (HELO mail-we0-f174.google.com) (74.125.82.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 02 Apr 2014 20:47:04 +0000 Received: by mail-we0-f174.google.com with SMTP id t60so826921wes.19 for ; Wed, 02 Apr 2014 13:47:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=gYrreIoblP5z/35OfLUmkQXXc57lNqBzTGNkEatnzEQ=; b=i6RXZTg27dSjVuuQUC/C8PvMN72T/CSkHzLLnriO6HzIIbNxRV7js1F3qIGEs8DNvo DRuwpe9leSC72s4uIA+YE+pfDtVGNxydejTX06Mwfik/N1bhrcJTHaZe7/3pf3mv6b6b bX8meHdz91D2nlQ+vJqMhUVNtRPo/3ATHDc/hPoDCulcZstM3u6biKB5TnnQrLgVUkTY 1PNobSCIlRTc51ZJe83M0G6Y5X6eilhNpRN449vnd00ZGWuBZ/Bmwd21k3H4N8xklAI3 uGbUULxhACqdiFJjGZ6obKDolaaDnWW5CxoDDM8orgFN/nYnAAj930Hzwc/0osB5zebi IEWA== X-Gm-Message-State: ALoCoQlpVfBOQ9ZXuJt3HovKbTwQ2DiFchlDGvnoss4izARUhU2qOW7EymZKY++84s2kQ6rt3XxgqVBR22arZH8EngFl5HkYujnPmCoyTGtT7VjiamArqgWAJL4a9mPW4HikTr8VgmPRMuAoyZUDjcRebQTEJH/Y9T3OSCbKmzWS+2+ZucSLTu7lhwTM/2zb6yP2vBmTOb2+WWyHQtJ7nWzYzQsRI9D9dw== MIME-Version: 1.0 X-Received: by 10.181.13.112 with SMTP id ex16mr31621949wid.23.1396471620310; Wed, 02 Apr 2014 13:47:00 -0700 (PDT) Received: by 10.15.48.194 with HTTP; Wed, 2 Apr 2014 13:46:58 -0700 (PDT) Date: Wed, 2 Apr 2014 13:46:58 -0700 Message-ID: Subject: [PING] [PATCH] [Python] Fix gdb.Value.dynamic_type for reference values From: Siva Chandra To: gdb-patches X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in Original post: https://sourceware.org/ml/gdb-patches/2014-03/msg00542.html gdb.Value.dynamic_type is supposed to work for reference and pointer values. However, the value object in the function 'valpy_get_dynamic_type' was being dereferenced using 'value_ind' irrespective of the value type being TYPE_CODE_PTR or TYPE_CODE_REF. This patch fixes that to use 'coerce_ref' for TYPE_CODE_REF values. ChangeLog: 2014-04-02 Siva Chandra Reddy * python/py-value.c (valpy_get_dynamic_type): Use coerce_ref to dereference TYPE_CODE_REF values. testsuite/ * gdb.python/py-value.c: Improve test case. * gdb.python/py-value.exp: Add new test. diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c index a118f6c..54da67a 100644 --- a/gdb/python/py-value.c +++ b/gdb/python/py-value.c @@ -309,7 +309,10 @@ valpy_get_dynamic_type (PyObject *self, void *closure) struct value *target; int was_pointer = TYPE_CODE (type) == TYPE_CODE_PTR; - target = value_ind (val); + if (was_pointer) + target = value_ind (val); + else + target = coerce_ref (val); type = value_rtti_type (target, NULL, NULL, NULL); if (type) diff --git a/gdb/testsuite/gdb.python/py-value.c b/gdb/testsuite/gdb.python/py-value.c index 90dc055..4d1c9c6 100644 --- a/gdb/testsuite/gdb.python/py-value.c +++ b/gdb/testsuite/gdb.python/py-value.c @@ -58,6 +58,8 @@ struct Derived : public Base { }; Base *base = new Derived (); +Derived derived; +Base &base_ref = derived; void ptr_ref(int*& rptr_int) { diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp index ed332db..13433fd 100644 --- a/gdb/testsuite/gdb.python/py-value.exp +++ b/gdb/testsuite/gdb.python/py-value.exp @@ -416,6 +416,8 @@ proc test_subscript_regression {exefile lang} { # Likewise. gdb_test "python print (gdb.parse_and_eval('base').dynamic_type)" \ "Derived \[*\]" + gdb_test "python print (gdb.parse_and_eval('base_ref').dynamic_type)" \ + "Derived \[&\]" # A static type case. gdb_test "python print (gdb.parse_and_eval('5').dynamic_type)" \ "int"