diff mbox

Remove unused and probably incorrect macro TYPE_FN_FIELDS

Message ID CAGyQ6gwQ8shtKNL_0d4C9rd-_hBjVfSGg7t5zFCDCuYSiT=U-g@mail.gmail.com
State Committed
Headers

Commit Message

Siva Chandra Reddy April 16, 2014, 12:10 p.m. UTC 
  Probably an obvious commit, but I might not be aware of any historical
decision around this.

Patch is attached. Tested by building on x86_64 GNU/Linux.

2014-04-16  Siva Chandra Reddy  <sivachandra@google.com>

        * gdbtypes.h: Remove definition of the macro TYPE_FN_FIELDS.

Comments

Joel Brobecker April 16, 2014, 3:36 p.m. UTC | #1 
> 2014-04-16  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         * gdbtypes.h: Remove definition of the macro TYPE_FN_FIELDS.

I'm not aware of the history either, but it's really easy to put back
should there be any reason to, so go ahead and push.

Thanks!

> diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
> index e91ab97..e63d255 100644
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -1205,7 +1205,6 @@ extern void allocate_gnat_aux_type (struct type *);
>  #define TYPE_VPTR_BASETYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
>  #define TYPE_DOMAIN_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
>  #define TYPE_VPTR_FIELDNO(thistype) TYPE_MAIN_TYPE(thistype)->vptr_fieldno
> -#define TYPE_FN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->fn_fields
>  #define TYPE_NFN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->nfn_fields
>  #define TYPE_SPECIFIC_FIELD(thistype) \
>    TYPE_MAIN_TYPE(thistype)->type_specific_field
Siva Chandra Reddy April 16, 2014, 10:45 p.m. UTC | #2 
On Wed, Apr 16, 2014 at 8:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2014-04-16  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>         * gdbtypes.h: Remove definition of the macro TYPE_FN_FIELDS.
>
> I'm not aware of the history either, but it's really easy to put back
> should there be any reason to, so go ahead and push.

Done, but with two pushes as I missed adding the ChangeLog entry in
the first push:
8000c58e455259951daa4370631aa616b367d1a7 and
7a23c5494be60600d34527f5adeaa2a34b85fdb6
diff mbox

Patch

diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index e91ab97..e63d255 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -1205,7 +1205,6 @@  extern void allocate_gnat_aux_type (struct type *);
 #define TYPE_VPTR_BASETYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
 #define TYPE_DOMAIN_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
 #define TYPE_VPTR_FIELDNO(thistype) TYPE_MAIN_TYPE(thistype)->vptr_fieldno
-#define TYPE_FN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->fn_fields
 #define TYPE_NFN_FIELDS(thistype) TYPE_CPLUS_SPECIFIC(thistype)->nfn_fields
 #define TYPE_SPECIFIC_FIELD(thistype) \
   TYPE_MAIN_TYPE(thistype)->type_specific_field