From patchwork Tue Oct 13 15:33:50 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: David Edelsohn <dje.gcc@gmail.com>
X-Patchwork-Id: 9082
Received: (qmail 20371 invoked by alias); 13 Oct 2015 15:33:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 20358 invoked by uid 89); 13 Oct 2015 15:33:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00,
	FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,
	SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ig0-f182.google.com
Received: from mail-ig0-f182.google.com (HELO mail-ig0-f182.google.com)
	(209.85.213.182) by sourceware.org
	(qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256
	encrypted) ESMTPS; Tue, 13 Oct 2015 15:33:52 +0000
Received: by igbif5 with SMTP id if5so2068654igb.1 for
	<gdb-patches@sourceware.org>; Tue, 13 Oct 2015 08:33:50 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.50.111.137 with SMTP id ii9mr20753796igb.91.1444750430388;
	Tue, 13 Oct 2015 08:33:50 -0700 (PDT)
Received: by 10.36.133.5 with HTTP; Tue, 13 Oct 2015 08:33:50 -0700 (PDT)
In-Reply-To: <20151012183438.GE3341@adacore.com>
References: 
 <CADPb22RhyhWrxLu2vy-TOp7ua97BWBJ6Loa9puoSFiYZq82NBg@mail.gmail.com>
	<20151006165157.GA3341@adacore.com>
	<CAGWvnykS9J5cHfbDg4swVhXZdJ+Lzk7JQmikbPrXh2E4p-xshg@mail.gmail.com>
	<CADPb22Q1s4q7NCzUO5iLt0cT8ewH21RhmHTnyPh7AS=4nhFmsw@mail.gmail.com>
	<CAGWvnymgdDdzeKNDrjrwwTnO9dPrkcfJjOhJJn9RjGX_+BheJQ@mail.gmail.com>
	<20151010000433.GB3341@adacore.com>
	<CADPb22QmuPeP_QBDNWA4iSi1jsnTvAiAurV8HWGCAYnPoMr+wg@mail.gmail.com>
	<CAGWvnyn51SPQeHvS3xNmc+9J8VwXiL1d94uVR84z_=4EYwdF+Q@mail.gmail.com>
	<20151012155021.GC3341@adacore.com>
	<CAGWvny=kgerJJokbsBz=h=1icH90ePjRCHzpi+GM+_nbiiuhjQ@mail.gmail.com>
	<20151012183438.GE3341@adacore.com>
Date: Tue, 13 Oct 2015 11:33:50 -0400
Message-ID: 
 <CAGWvny=suvd=yEC3WYd9YpsLaW_O+zCQSXBm=tfekeutyZ6xUQ@mail.gmail.com>
Subject: Re: AIX DWARF debugging sections
From: David Edelsohn <dje.gcc@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Doug Evans <dje@google.com>, Tristan Gingold <gingold@adacore.com>,
	GDB Patches <gdb-patches@sourceware.org>

On Mon, Oct 12, 2015 at 2:34 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Thanks, David
>>
>> * xcoffread (dwrf2_xcoff_names): Add .dwmac and .dwpbtyp.
>
> Looks good to me with just one nit.
> the GNU Coding Standards ask us that sentences end with a period. So
> unfortunately, we're going to have to split that line in two.

For full sentences, we might as well document it more completely.

Thanks, David

   { NULL, NULL }, /* eh_frame */

diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 0d49751..e4af37c 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -159,11 +159,14 @@ static const struct dwarf2_debug_sections dwarf2_xcoff_nam
es = {
   { ".dwabrev", NULL },
   { ".dwline", NULL },
   { ".dwloc", NULL },
-  { NULL, NULL }, /* debug_macinfo */
-  { NULL, NULL }, /* debug_macro */
+  /* AIX XCOFF defines one, named DWARF section for macro debug information.
+     XLC does not generate debug_macinfo for DWARF4 and below.
+     The section is assigned to debug_macro for DWARF5 and above. */
+  { NULL, NULL },
+  { ".dwmac", NULL },
   { ".dwstr", NULL },
   { ".dwrnges", NULL },
-  { NULL, NULL }, /* debug_types */
+  { ".dwpbtyp", NULL },
   { NULL, NULL }, /* debug_addr */
   { ".dwframe", NULL },