diff mbox

[rs6000] : Remove write-only assignment

Message ID CAFULd4YAzfYWTnEL2atrMdSKz2vtegw_WOh7hZNH3LXfQhKdfw@mail.gmail.com
State New
Headers show

Commit Message

Uros Bizjak Dec. 19, 2017, 12:33 p.m. UTC
2017-12-19  Uros Bizjak  <ubizjak@gmail.com>

    * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
    write-only assignment to "insn" variable.

Uros.

Comments

Yao Qi Dec. 20, 2017, 11:50 a.m. UTC | #1
Uros Bizjak <ubizjak@gmail.com> writes:

> 2017-12-19  Uros Bizjak  <ubizjak@gmail.com>
>
>     * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
>     write-only assignment to "insn" variable.

Patch is good to me.
Uros Bizjak Dec. 20, 2017, 11:55 a.m. UTC | #2
On Wed, Dec 20, 2017 at 12:50 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Uros Bizjak <ubizjak@gmail.com> writes:
>
>> 2017-12-19  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
>>     write-only assignment to "insn" variable.
>
> Patch is good to me.

I have no committ rights, can someone please commit the patch for me?

Uros.
Simon Marchi Dec. 21, 2017, 1:43 a.m. UTC | #3
On 2017-12-20 06:55, Uros Bizjak wrote:
> On Wed, Dec 20, 2017 at 12:50 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
>> Uros Bizjak <ubizjak@gmail.com> writes:
>> 
>>> 2017-12-19  Uros Bizjak  <ubizjak@gmail.com>
>>> 
>>>     * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
>>>     write-only assignment to "insn" variable.
>> 
>> Patch is good to me.
> 
> I have no committ rights, can someone please commit the patch for me?
> 
> Uros.

Pushed, thanks for the patch.

Simon
diff mbox

Patch

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index eb784c562f..e8f21a7fc3 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -1225,7 +1225,6 @@  ppc_deal_with_atomic_sequence (struct regcache *regcache)
 
   closing_insn = loc;
   loc += PPC_INSN_SIZE;
-  insn = read_memory_integer (loc, PPC_INSN_SIZE, byte_order);
 
   /* Insert a breakpoint right after the end of the atomic sequence.  */
   breaks[0] = loc;