From patchwork Mon Jul 20 19:14:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 7766 Received: (qmail 65049 invoked by alias); 20 Jul 2015 19:14:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65014 invoked by uid 89); 20 Jul 2015 19:14:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 20 Jul 2015 19:14:07 +0000 Received: by wibxm9 with SMTP id xm9so100261101wib.0 for ; Mon, 20 Jul 2015 12:14:04 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.97.7 with SMTP id dw7mr24698523wib.74.1437419644837; Mon, 20 Jul 2015 12:14:04 -0700 (PDT) Received: by 10.27.11.33 with HTTP; Mon, 20 Jul 2015 12:14:04 -0700 (PDT) Date: Mon, 20 Jul 2015 21:14:04 +0200 Message-ID: Subject: [PATCH] bfd: Fix regression when building bfd on mingw32 From: Iain Buclaw To: gdb-patches@sourceware.org, lgustavo@codesourcery.com X-IsSubscribed: yes Hi, This patch is as per suggestion from Pedro, I've also added a check for vasprintf just for completeness sake, and that there is a similar condition for HAVE_DECL_VASPRINTF in libiberty.h. https://sourceware.org/ml/gdb-patches/2015-06/msg00654.html As per my comments earlier, I am going blind on this, but it looks correct to me, and I can at least verify on my machine that I can see: configure stage --- checking whether asprintf is declared... yes checking whether vasprintf is declared... yes --- config.h --- /* Define to 1 if you have the declaration of `asprintf', and to 0 if you don't. */ #define HAVE_DECL_ASPRINTF 1 /* Define to 1 if you have the declaration of `vasprintf', and to 0 if you don't. */ #define HAVE_DECL_VASPRINTF 1 --- So should either one be false, they should have a proper declaration in libiberty.h Luis, can you check this patch is good for you? Regards Iain --- 2015-07-20 Iain Buclaw * configure.in: Add asprintf and vasprintf to AC_CHECK_DECLS. * config.in, configure: Regenerate. --- a/bfd/config.in +++ b/bfd/config.in @@ -17,6 +17,10 @@ /* Define to 1 if you have the header file. */ #undef HAVE_ALLOCA_H +/* Define to 1 if you have the declaration of `asprintf', and to 0 if you + don't. */ +#undef HAVE_DECL_ASPRINTF + /* Define to 1 if you have the declaration of `basename', and to 0 if you don't. */ #undef HAVE_DECL_BASENAME @@ -72,6 +76,10 @@ */ #undef HAVE_DECL_STRSTR +/* Define to 1 if you have the declaration of `vasprintf', and to 0 if you + don't. */ +#undef HAVE_DECL_VASPRINTF + /* Define to 1 if you have the declaration of `vsnprintf', and to 0 if you don't. */ #undef HAVE_DECL_VSNPRINTF --- a/bfd/configure +++ b/bfd/configure @@ -13819,6 +13819,28 @@ cat >>confdefs.h <<_ACEOF #define HAVE_DECL_STRSTR $ac_have_decl _ACEOF +ac_fn_c_check_decl "$LINENO" "asprintf" "ac_cv_have_decl_asprintf" "$ac_includes_default" +if test "x$ac_cv_have_decl_asprintf" = x""yes; then : + ac_have_decl=1 +else + ac_have_decl=0 +fi + +cat >>confdefs.h <<_ACEOF +#define HAVE_DECL_ASPRINTF $ac_have_decl +_ACEOF + +ac_fn_c_check_decl "$LINENO" "vasprintf" "ac_cv_have_decl_vasprintf" "$ac_includes_default" +if test "x$ac_cv_have_decl_vasprintf" = x""yes; then : + ac_have_decl=1 +else + ac_have_decl=0 +fi + +cat >>confdefs.h <<_ACEOF +#define HAVE_DECL_VASPRINTF $ac_have_decl +_ACEOF + ac_fn_c_check_decl "$LINENO" "snprintf" "ac_cv_have_decl_snprintf" "$ac_includes_default" if test "x$ac_cv_have_decl_snprintf" = x""yes; then : ac_have_decl=1 --- a/bfd/configure.ac +++ b/bfd/configure.ac @@ -232,6 +232,8 @@ AC_CHECK_DECLS(malloc) AC_CHECK_DECLS(realloc) AC_CHECK_DECLS(stpcpy) AC_CHECK_DECLS(strstr) +AC_CHECK_DECLS(asprintf) +AC_CHECK_DECLS(vasprintf) AC_CHECK_DECLS(snprintf) AC_CHECK_DECLS(vsnprintf) AC_CHECK_DECLS(strnlen)