From patchwork Sat Mar 4 22:15:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 19433 Received: (qmail 93963 invoked by alias); 4 Mar 2017 22:15:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 93947 invoked by uid 89); 4 Mar 2017 22:15:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=assemble, classified, watch X-HELO: mail-ua0-f176.google.com Received: from mail-ua0-f176.google.com (HELO mail-ua0-f176.google.com) (209.85.217.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Mar 2017 22:15:55 +0000 Received: by mail-ua0-f176.google.com with SMTP id f54so140184780uaa.1 for ; Sat, 04 Mar 2017 14:15:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=P6xYogZX+OVcEGCdX+snCaE/G+88D9wH9QOVl2SWx3o=; b=nkHq3TrD4mZa9sGDEJXkdaJB4/UBqYlgrij91m4WuVZAgdiLSKKDzI+uyioHD6sq9E gpFB07dITElIxiBFOXD+B8sus5GRQO/OdTCov6kxuVkUtiZvWqsDn7iPYJ0FNvXwC6QJ ajjzCqxKPpAuluqsvwqqI0TxOO4ZRaifCnzLk6legdyLwav7E5tgHF/RpBg4Ce0yBvMh 5vJ/3SF0stfdGMO3ZSUAlKaQhCxNAMXdB9TyeCO+CNpxxyzPWesl24X4Fl/9cQ6NT8g7 K7HEg4XJzcQFCemX5N16HJRjqGhwBKF0nxwxxBhGWC+lzuLp0C30IWEG3XS8exGz6gvT IDMw== X-Gm-Message-State: AMke39n5chg6G3cp1R7X0xhUaz11dEjY/USw+c+OgHcmLtGRRxxCkU/FyB77l+MWtuuznKhZ5VDPUT2a/WFaHA== X-Received: by 10.176.8.4 with SMTP id a4mr4541737uaf.171.1488665753734; Sat, 04 Mar 2017 14:15:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.31.41.81 with HTTP; Sat, 4 Mar 2017 14:15:53 -0800 (PST) From: Iain Buclaw Date: Sat, 4 Mar 2017 23:15:53 +0100 Message-ID: Subject: [PING] [PATCH] D: Fix classification of module.type in lexer To: GDB Patches X-IsSubscribed: yes Small ping on this. I'm confident about the source change is pretty much obvious, just want to make sure that the test is ok too. --- The two-tier lexer, whose job is to resolve fully qualified names missed a case where 'module.type' was not being classified as one token. And so when the Yacc grammar kicks in, it resolved the tokens as "TypeExp . IdentifierExp", which then will never match the rule for cast expressions "( TypeExp ) UnaryExpression". Adding a case for TYPE_CODE_MODULE in type_aggregate_p means that classify_inner_name will get a chance to look-up the symbol. This was noticed when someone tried 'watch -l', and got the rather confusing response: A syntax error in expression, near `) 0x000000010'. So it's been included in the testsuite, along with another test that does effectively the same expression explicitly. 2017-01-07 Iain Buclaw gdb/ChangeLog: * d-exp.y (type_aggregate_p): Treat TYPE_CODE_MODULE as being aggregate-like. gdb/testsuite/ChangeLog: * gdb.dlang/watch-loc.c: New file. * gdb.dlang/watch-loc.exp: New file. --- diff --git a/gdb/d-exp.y b/gdb/d-exp.y index 077e645..2dab00e 100644 --- a/gdb/d-exp.y +++ b/gdb/d-exp.y @@ -651,6 +651,7 @@ type_aggregate_p (struct type *type) { return (TYPE_CODE (type) == TYPE_CODE_STRUCT || TYPE_CODE (type) == TYPE_CODE_UNION + || TYPE_CODE (type) == TYPE_CODE_MODULE || (TYPE_CODE (type) == TYPE_CODE_ENUM && TYPE_DECLARED_CLASS (type))); } diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c new file mode 100644 index 0000000..725d1f1 --- /dev/null +++ b/gdb/testsuite/gdb.dlang/watch-loc.c @@ -0,0 +1,39 @@ +/* Copyright 2017 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + + +/* DWARF will describe these contents as being inside a D module. */ + +typedef struct tstruct +{ +} tstruct; + +tstruct my_data; + +asm ("dmain_start: .globl dmain_start"); + +int _Dmain (void) +{ + return 0; +} + +asm ("dmain_end: .globl dmain_end"); + +int +main (void) +{ + return _Dmain (); +} + diff --git a/gdb/testsuite/gdb.dlang/watch-loc.exp b/gdb/testsuite/gdb.dlang/watch-loc.exp new file mode 100644 index 0000000..b34a102 --- /dev/null +++ b/gdb/testsuite/gdb.dlang/watch-loc.exp @@ -0,0 +1,86 @@ +# Copyright (C) 2017 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test symbol lookup when there are multiple circular imports. + +load_lib "d-support.exp" +load_lib "dwarf.exp" + +if { [skip_d_tests] } { return -1 } + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +standard_testfile watch-loc.c watch-loc-dw.S + +# Make some DWARF for the test. +set asm_file [standard_output_file $srcfile2] +Dwarf::assemble $asm_file { + cu {} { + compile_unit { + {language @DW_LANG_D} + } { + declare_labels watch_module_label watch_struct_label + + extern dmain_start dmain_end + + watch_module_label: module { + {name watch} + } { + watch_struct_label: structure_type { + {name tstruct} + {byte_size 1 data1} + } + + tag_variable { + {name my_data} + {type :$watch_struct_label} + {location { + addr [gdb_target_symbol my_data] + } SPECIAL_expr} + {external 1 flag} + } + + subprogram { + {name "D main"} + {linkage_name "_Dmain"} + {external 1 flag_present} + {low_pc dmain_start addr} + {high_pc dmain_end addr} + } + } + } + } +} + +if { [prepare_for_testing "failed to prepare" ${testfile} \ + [list $srcfile $asm_file] {nodebug}] } { + return -1 +} + +gdb_test_no_output "set language d" + +if {![runto "_Dmain"]} { + return -1 +} + +# watch -l will rewrite the expression to "*(watch.tstruct *) 0x12345", +# this should not cause syntax error in the cast expression. +gdb_test "watch -l my_data" ".*atchpoint \[0-9\]+: -location my_data" + +# Same test as above, but done explicitly. +gdb_test "print *(watch.tstruct *) &my_data" "{}"