From patchwork Fri Apr 7 08:36:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19889 Received: (qmail 115306 invoked by alias); 7 Apr 2017 08:36:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 115272 invoked by uid 89); 7 Apr 2017 08:36:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1543 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0059.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.59) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Apr 2017 08:36:39 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Fri, 7 Apr 2017 08:36:38 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d%16]) with mapi id 15.01.1005.022; Fri, 7 Apr 2017 08:36:38 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: [PATCH] msp430: Don't use REG_UNKNOWN Date: Fri, 7 Apr 2017 08:36:38 +0000 Message-ID: authentication-results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0101; 7:i4O7ibUHPvdT+Y5XVgtcIPFCcv93YFTMLQf4o0oRnCu0DGFT0TvhCyxZD1PdV71eIgSaLda7Lnnb/Ri7t6lLyK6skgUlzHy8Pt4NTLcRICe75GXtfdRRj97V+uV+NZL63UJkOsro5SkF9/x8odtMAxJc3UcLz31VbUQ7b1PrWJwTiEkCvPbRVbbfOEeqxo9PXqBcQxbwUbBkPyLSE7ID2d4EOITsNAqOleEWjnIBh0d/XC/Zaqqv7y1HbYnLDxHm/fbAYqBENVcQSwo+leqS8LAvMyk82ODPzIL9JEuY+M53SCSqsJBmPwVzjuf3sf1NR32XzMeqco6FPmwsDlVV0A== x-ms-office365-filtering-correlation-id: 2972ccc5-2274-4198-dd6d-08d47d913564 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM3PR08MB0101; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(6072148); SRVR:AM3PR08MB0101; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0101; x-forefront-prvs: 0270ED2845 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39840400002)(39450400003)(39860400002)(377424004)(6116002)(102836003)(3846002)(5640700003)(99286003)(5660300001)(6512007)(6916009)(189998001)(2900100001)(575784001)(86362001)(8936002)(53936002)(2906002)(3280700002)(3660700001)(2351001)(81166006)(8676002)(33656002)(38730400002)(110136004)(4326008)(25786009)(66066001)(54356999)(50986999)(6436002)(6486002)(305945005)(6506006)(36756003)(2501003)(461764006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0101; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <5044B3549B4CDA4F94D9B9CC1D1638DD@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2017 08:36:38.4374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 This patch is cut from "[PATCH] Remove MAX_REGISTER_SIZE from regcache.c" This patch simply makes it more obvious that msp430_pseudo_register_read () cannot return REG_UNKNOWN. This is required due to some regcache refactoring (see the “Remove MAX_REGISTER_SIZE from regcache.c" thread). Tested on a --enable-targets=all build using make check with board files unix and native-gdbserver. I do not have a msp430 machine to test on. Ok to commit? Alan. 2017-04-06 Alan Hayward * msp430-tdep.c (msp430_pseudo_register_read): Never return REG_UNKNOWN. diff --git a/gdb/msp430-tdep.c b/gdb/msp430-tdep.c index 75329dfcc5ed94fff19639db4db21dd0874d0e96..d9eebf0cc2647a079db2f822145d0fb74ea301e4 100644 --- a/gdb/msp430-tdep.c +++ b/gdb/msp430-tdep.c @@ -221,10 +221,9 @@ msp430_pseudo_register_read (struct gdbarch *gdbarch, struct regcache *regcache, int regnum, gdb_byte *buffer) { - enum register_status status = REG_UNKNOWN; - if (MSP430_NUM_REGS <= regnum && regnum < MSP430_NUM_TOTAL_REGS) { + enum register_status status; ULONGEST val; enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); int regsize = register_size (gdbarch, regnum); @@ -234,11 +233,10 @@ msp430_pseudo_register_read (struct gdbarch *gdbarch, if (status == REG_VALID) store_unsigned_integer (buffer, regsize, byte_order, val); + return status; } else gdb_assert_not_reached ("invalid pseudo register number"); - - return status; } /* Implement the "pseudo_register_write" gdbarch method. */