diff mbox

[v2,5/7] btrace, gdbserver: remove the to_supports_btrace target method

Message ID A78C989F6D9628469189715575E55B236964DF48@IRSMSX104.ger.corp.intel.com
State New, archived
Headers

Commit Message

Metzger, Markus T Feb. 28, 2018, 12:53 p.m. UTC 
  Hello Maciej,

I wondered why my fill-column auto-mode settings didn't seem to be effective and found
that they were overwritten by gdb/.dir-locals.el.

If you want to enforce the 74 columns limit, you may want to submit the below patch.

I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest.
IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'.
Are you OK with that?

Regards,
Markus.

---




> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Metzger, Markus T
> Sent: 28 February 2018 12:24
> To: Maciej W. Rozycki <macro@mips.com>
> Cc: gdb-patches@sourceware.org
> Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace
> target method
> 
> Hello Maciej,
> 
> I added
> 
> 	(setq fill-column 74)
> 
> for COMMIT_EDITMSG and for *.[hc] files.  This excludes .exp and .texinfo (and
> others), which are still at 80 columns.
> 
> Also for command help-text strings I believe it makes sense to stay at 80 columns.
> 
> Are you OK with that?
> 
> Regards,
> Markus.
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of
> the Supervisory Board: Nicole Lau Registered Office: Munich Commercial
> Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Comments

Maciej W. Rozycki Feb. 28, 2018, 3:15 p.m. UTC | #1 
Hi Markus,

> I wondered why my fill-column auto-mode settings didn't seem to be effective and found
> that they were overwritten by gdb/.dir-locals.el.
> 
> If you want to enforce the 74 columns limit, you may want to submit the below patch.

 I don't use Emacs so I can't comment on technical details of your change, 
although at the high level it does look reasonable to me.

> I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest.
> IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'.
> Are you OK with that?

 As I say we have the formatting rules set as documented in our wiki, so 
please do follow them, or if you want to get them changed, then you need 
to reach consensus about your proposal among GDB maintainers.

  Maciej
Eli Zaretskii Feb. 28, 2018, 4:08 p.m. UTC | #2 
> From: "Metzger, Markus T" <markus.t.metzger@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Wed, 28 Feb 2018 12:53:15 +0000
> 
> I wondered why my fill-column auto-mode settings didn't seem to be effective and found
> that they were overwritten by gdb/.dir-locals.el.
> 
> If you want to enforce the 74 columns limit, you may want to submit the below patch.
> 
> I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest.
> IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'.
> Are you OK with that?

I believe this value is so we could some day produce ChangeLog files
from Git log.
diff mbox

Patch

diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el
index 7e2b0cc..abfd167 100644
--- a/gdb/.dir-locals.el
+++ b/gdb/.dir-locals.el
@@ -21,6 +21,7 @@ 
  (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
  (c-mode . ((c-file-style . "GNU")
            (mode . c++)
+           (fill-column . 74)
            (indent-tabs-mode . t)
            (tab-width . 8)
            (c-basic-offset . 2)