From patchwork Sat Apr 6 17:03:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88132 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E3FA13858C53 for ; Sat, 6 Apr 2024 17:04:28 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4B16D3858C53 for ; Sat, 6 Apr 2024 17:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B16D3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B16D3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423006; cv=none; b=hVUNrBAYxgYNq81lQirsWdA9jZj3Ds/6dCzDVI/H5Pstvr6Dax8y6+EhAwBGdRVHwmMDr9okaURvKehMT7dw7FCkZSYfVw2rCrT6H7Yeix03QWi3DF70Wd74RP354C6sxgOpz3Ib2vIF3ru+fhDnzVt8I48Hh5qM8YyW03DMEyw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423006; c=relaxed/simple; bh=Bz5nS2p/Cd/qgne2owoGb9RgYAYKxp8uvCJm2LlHTTs=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=bTlRmvBuisVo/LPaTnejd3HC03fE5C/t/f+brgvuL9TN68Th9RpHTAIJ7QNpmJcsESPUuqpzeTUWWBJOnMvJibzv/vjpkAoM0B2kZWlE/V9f/uxYTL06CKLjaaiJQ+0lAaSuSiWm9EUx8tVuruSvgqmc5yht57/9eZfE4O3K2pY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pvQUAOxkzDJFKXx4dULwEpeooPR78Tg7S79G2SPNYxA=; b=Yh7XFmDrIF5aUzxBmemZhA/h3+SgLAexIrcsQBpvwMTjA2TZv26QLLUD4pGnBW6C6Macge nEgJ9viHW51pr4H1IxlP7CTQAv6LknksTJp4m0/r6mHTzrrOyO+6nhHioTJzHYyBHEltmm V2F3bY71l3OEaYMA8kABDeRRBv91XfE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-gAO6VBetMZykX_0Wd0EDeQ-1; Sat, 06 Apr 2024 13:03:23 -0400 X-MC-Unique: gAO6VBetMZykX_0Wd0EDeQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a5190b1453fso167170466b.2 for ; Sat, 06 Apr 2024 10:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423001; x=1713027801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pvQUAOxkzDJFKXx4dULwEpeooPR78Tg7S79G2SPNYxA=; b=LDOG9mzxNTax3WpXCcxkQpZdDKKfKnwvpCJ/MTOhyL+8g8T17inz23sp8Pa6BYrqhV j4tAa29+ha5QAlBJgNVlmamtE/MJ9cja9CD7m1mhw4AGJcQJmft2+AiwD8gYx1Rl/jOd x4hJbj6zvfQp1z69j2pE6eGke1Atgh09++qesPgF/YU6kH4El8zUPejVAJzxLEm/8qxH A8qPZnNkWTjZujNAaIkQscLSdWnDRtsilCJpTUa3qWqc6wxn+IoIFRAvYIyJFjzFwACX 2/JWHiX3CH8zOGIH+oKbZmSAnc50lMkFtPU3BaxVZbv8vaKQeCka9VsHkHtawoSkiDWX BErA== X-Gm-Message-State: AOJu0YxYnlsie9xVv0RmrvkwGCcK58ijSk6tVkFFJAS76KHeVE1OLtEK 1rfcA0UPR8dqmuadws5DM1K4l73MVEk/elKUZ87SVFSVNkcyh2PcG9l4D6KZaainu5ZP3HY3dvs ljMj3XBq/hMGGt2ttO6OwFyaqoTD45rfRAhYBUBksxsm2gf2HVomataqU8zOs6G/QSkes2+Zb36 9eO3MgNBxMT6OM7iPZ2+EHKTlM8UleK+4ylvg6Mnt+JPY= X-Received: by 2002:a17:906:2488:b0:a46:8daa:436f with SMTP id e8-20020a170906248800b00a468daa436fmr2842596ejb.69.1712423000963; Sat, 06 Apr 2024 10:03:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEaMPJvWT+3JUVIVLHjYfs+R74QVHOnNTtONpo+J3H+KH55p1/F9NqLUcc4b6AvA78wT2V6g== X-Received: by 2002:a17:906:2488:b0:a46:8daa:436f with SMTP id e8-20020a170906248800b00a468daa436fmr2842582ejb.69.1712423000442; Sat, 06 Apr 2024 10:03:20 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id cw23-20020a170906c79700b00a51bf5932aesm650900ejb.28.2024.04.06.10.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:20 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 1/6] gdb/Makefile: add gcore to the 'all' target dependency list Date: Sat, 6 Apr 2024 18:03:10 +0100 Message-Id: <9c6e7010992178e170fa30092d48d9a37dd2315b.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The gcore script is initially generated by the configure process, just like gdb-gdb.gdb and gdb-gdb.py. However if the gdb/gcore.in input source is modified then 'make all' in the gdb/ directory does not regenerate the gcore script. This is different than the gdb-gdb.gdb and gdb-gdb.py files, if their input is updated then 'make all' will regenerate these files. The difference is that for gdb-gdb.* there is an explicit dependency between the 'all' target and the generated file, this dependency is missing for gcore. This commit adds the dependency. Now, if gcore.in is changed, running 'make all' will regenerate the gcore script. There is no change in _what_ is generated after this commit. --- gdb/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index a9f641c0659..df044288b5e 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1938,7 +1938,7 @@ generated_files = \ # Flags needed to compile Python code PYTHON_CFLAGS = @PYTHON_CFLAGS@ -all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb +all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb gcore @$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=$(SUBDIRS)" subdir_do # Rule for compiling .c files in the top-level gdb directory.