From patchwork Thu May 31 15:19:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 27593 Received: (qmail 113643 invoked by alias); 31 May 2018 15:20:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113630 invoked by uid 89); 31 May 2018 15:20:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 15:20:14 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 3E.DD.00712.BA2101B5; Thu, 31 May 2018 17:20:12 +0200 (CEST) Received: from ESESSMR501.ericsson.se (153.88.183.108) by ESESSHC021.ericsson.se (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 31 May 2018 17:20:03 +0200 Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMR501.ericsson.se (153.88.183.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 31 May 2018 17:20:03 +0200 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 31 May 2018 17:20:02 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.230.254] (129.192.64.65) by DM6PR15MB2394.namprd15.prod.outlook.com (2603:10b6:5:8d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.797.11; Thu, 31 May 2018 15:20:00 +0000 Subject: Re: [PATCH]: Fix PR19061, gdb hangs/spins-on-cpu when debugging any program on Alpha To: Simon Marchi , Uros Bizjak CC: , Tobias Klausmann , References: <56293ba8-f95b-5da1-af14-7500a0f8f892@ericsson.com> <4a93db59737d2b7ebbea5982180f16d2@polymtl.ca> From: Simon Marchi Message-ID: <94b25728-eef3-e23d-6582-6cb01602342d@ericsson.com> Date: Thu, 31 May 2018 11:19:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <4a93db59737d2b7ebbea5982180f16d2@polymtl.ca> X-ClientProxiedBy: YQXPR0101CA0015.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::28) To DM6PR15MB2394.namprd15.prod.outlook.com (2603:10b6:5:8d::28) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM6PR15MB2394; X-Microsoft-Exchange-Diagnostics: 1; DM6PR15MB2394; 3:SgoykNTs0h+m2tzKzcDIuHbI9WocligxpyAQ7E2g9VJDQYrzY9RrIJvktPCbQaOndM9Z5YPFQhq0H0wpUxjsCwo74QHTJQpZG/FKUAE89yKWamrvLEnruRJlZaex1YM/5fINC2574Y/erqFV5sW8PvQxX3M6uYGCKUTk2oxh9p432qaEZ+cPKWZ1AHaqnf7SvNOLvs0y5sOxESVfRsSOWLdbFC00rDkcOhVPXG6MpeU9lXhCOWF0f6qvIFqAe9hQ; 25:rzp4buHwNPlRO35Iox0FY2A9IxubFGx1cL3/phsnzdetoJToTs6/zayhlSXeDxbF20wnNziRDVWTkXLiJbtqJzQSX3ePU6c1bqxr2iA0D73+gL2W1fqoMWo9ZaoxOswg0buK5ZdhyNZN3zHRrs6wr8r8cVlAOukhRDN8V8V1GoFqnsMymkMaFJt1yvrMrCDWF7yV68BizWL45p1uDWBEUxGAqxz5YV97UzjuHgvjD5yXCVKrLVdS5QFODEL+rhY5YummpV5ZGatmJ2QWoW+74QmD5LIA580Mvzlm2T2yAy0tcdfNNThLxKN35JGspGYWAfS3GuNSg8DgQUI0pRSgRA==; 31:a/vfnpNmBCx3q9KkKifQVpGZ5LsEFqwQ0G/tQ71mvZ7+aAhv/GlQifXAqOCCKeU36dSyuvTveou8H/4btYB/c5GXbJylUrJoUiDxvPweY14wCLOpZVUkpjDluAJnYZ1JEY0W1cMMRwDOmotXQmQ3i/80LiL7C2dpcTgZnCZC72tYIZ/oNYku61v7GvDWONkMT+ODsC+UzZsz+sUNQLAPrQGwWHHoBS31pH0FR988O2Q= X-MS-TrafficTypeDiagnostic: DM6PR15MB2394: X-Microsoft-Exchange-Diagnostics: 1; DM6PR15MB2394; 20:3VHGaaPyEpr2GiB/HnLrbrWAhnpXo05mKY+XI71b+71CBcDKO1YLFVfcNQf0QZB00xSGdeYKkhNK5PdoSjNcsfkDG8fykMihTGDClkvSoZhjXLKREj40POUtZdpHHg3QEQNm/dY5rw76qrwn8zenD1mUwdJ4VJNc3ywJMcP/z7I9OiwgOGgGVdR7qgY4CZzn0bWKMKni+qQ47rXS9z1hU3JmOdobokmHIGEO01ZifLWYnIS5ia1LlOdUoA8SP8DDnejaWco6gIC2dAHBfMsoH57CWehVMs0yy3yJjDJ6TiIS3XV8DMXUO0DA2fIFuH4Nu0BjhPmY+PBE0cvS7uEAkPtmYbGyUi1KbCO+k2MmoyLoFnRzcjPtBV5HtK4TxICiknBNzVVKAcI/VB/bXpVCumaFYSE2a/vMVEUGZmB2AGwiO0dL0BxDqf1LurjQduaWMU9eA/kC+fbcw63jVPNP/LLRrwjWPQNoHLKOd+Fk7NACkmaTBnbSz/S/7tn74r5S; 4:n0GEDoJ+be7IZG4vnso8u9+PicgWx/B+WbBMwjzoLJnYZsIt1F5f7U2XFEWZ62wEc5LleJlMuEoLmZUQyKqWrDStZ8/mKS8d/Z2Zg/1uWBKEkrwfwZhn2253qDsikx/gtMho8ZM7R+sYj6PLqXDmAL+U+oIhRJDXcRmpswA7nl74BFAReUng1Jz+2XoYBFCGSCyvWRFObbS9XnSdI+MAHET2t2DCw9n80B12Rbtymw9ErOHjZuJtH/EGppA44O/xrBLqFworm53WWDQQerDAzMwQtM2AwvNWIqTlQzBSfQY/432CbTk8JECteldjB3qSpkfsKExrZCKTeeOIn6HI/12vTdJYN0cJbuAgSUxZOSj3Cv6u4ijoeVeep25/GcQY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322)(20558992708506)(85827821059158); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DM6PR15MB2394; BCL:0; PCL:0; RULEID:; SRVR:DM6PR15MB2394; X-Forefront-PRVS: 06891E23FB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(366004)(39380400002)(39860400002)(346002)(376002)(54534003)(189003)(199004)(7736002)(2870700001)(23676004)(16526019)(81156014)(81166006)(6486002)(50466002)(8676002)(186003)(229853002)(86362001)(64126003)(305945005)(31696002)(105586002)(49976009)(106356001)(6116002)(3846002)(44832011)(956004)(11346002)(2616005)(486006)(476003)(97736004)(446003)(47776003)(65956001)(66066001)(65806001)(8936002)(26005)(31686004)(39060400002)(68736007)(316002)(6246003)(53546011)(2906002)(59450400001)(4326008)(52116002)(93886005)(110136005)(386003)(76176011)(58126008)(25786009)(6666003)(53936002)(52146003)(16576012)(5890100001)(478600001)(5660300001)(36756003)(2486003)(65826007)(78286006); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR15MB2394; H:[100.94.230.254]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTZQUjE1TUIyMzk0OzIzOjR4cFZyaGtLSStLR2plNHFSZCt2S1gxd24y?= =?utf-8?B?MEk2VjhvWjF2eFYvcERFYXNTQ0RqbEtnajVoaTlvVU15YjJ4eTM2blc2amtn?= =?utf-8?B?SzE3YTlReFh5L24vdjVnc0MrSitQSlplMmxJWktlYVRzMzdMRHN0bktnWXJF?= =?utf-8?B?TGJUYnIwakFhZTVRWGllbE55Skpuc1BnSSt1S2pYV0xmZEwwY2ZVM05VbkQ5?= =?utf-8?B?U0ZZK0M5MjU0ZVZJZ0Y4S3lycmpYQnU4MWpaOHMvME0zT1g2R1BwK085Vzl3?= =?utf-8?B?OFBRODc0QkpKR2hWejJZMUlFbVRwZk40OHlVbis4KzZPOUxoNmw3TzBJV1Jk?= =?utf-8?B?bndBMnJEUktvQWcrNEJreU1MUk9tVkpoZ0dxQVNOck1TbmNmN0FrWjRtZ0pO?= =?utf-8?B?ZG1qTWIxR1lHV2xqR1kwdW9MaGg0NHovaHJXejMrV0hncUZ4eGdOMTRFNWpX?= =?utf-8?B?YWx3TTJiMXNWekRpdEp5NW1XTkw2YWlqUEI2YitDU3BJTTFiTm9mMzlIclhZ?= =?utf-8?B?MDdwUTJPY0VHOWhvTm5sNjFXN2JIbWIxR0tRcTlFUktqMmoyU3YxYWRpTURM?= =?utf-8?B?WndWa01Dckw3d1F6Q21CTGZBRHBrb0FyTTM3WS95NGluSVA3WFVKWjVWUnh4?= =?utf-8?B?aUpYcGdacndHWnVZK25NaGlORHZrNGFRWldEUGpHNmtYVXV2VG9ja0UrSFQ2?= =?utf-8?B?R2JVa0JhUkp2ajJCOE9ocU1OTW5Fc0NyTHA0eG16YlBzU3JwNy9xR3VSdG0z?= =?utf-8?B?SVJKSmlPSndjQjRQYk5BY1pDQzZHU3NZQm5nbUVpck1rNUhlR1ZqaUUxZUxs?= =?utf-8?B?Y3VMS3VTbXZYcWRiYVlJSWI2YnF6OExtcEVOdjFWTDBGamJrSllueXI2MUlW?= =?utf-8?B?VFplbTY2TWNWcUdUTGl2S3BUa2JqNlY4QWVPYXZiY2g4bHJnL282N2NYWnlr?= =?utf-8?B?MDhicXJNdzg4L09ybXhzSzNCcEtTa3dlNURLZzE0Q0dPVkZmWld2ZHhPVDhh?= =?utf-8?B?dXJHcHNlYTIrU0FkR1RVUy91NTN2d0FhVHNlL1pSQ3YwZDNnMnByLzlsZElk?= =?utf-8?B?cjcyY2doRHJ0VGFrOHRnS0VEQzRDV05xRWhQelNadzFFRSt2aE45ejI2WmlW?= =?utf-8?B?SHU1UDJ0OUN1Mm9TUkl2MEc4WVd1bHlyeGhjZE1nRlZMOG5iNGNvVFRuTm1R?= =?utf-8?B?QVlhNjlaYUZXVzRJY1VQSXQ0U0tjYmh2NDVvYmthZW9CbmFQbmJaUnBCRTRL?= =?utf-8?B?eGdnd0xSVXNWVHJYTlVCUG9vWTRIRm1iOXQ5WGxWQXZVQVBpQkUzK1pBY256?= =?utf-8?B?SDdReDVKK2VRSUxsTEJyWU9xMmhLdnpYWDdaWjZvcS9pYlNWR0xNOGFDemJx?= =?utf-8?B?TS9jclkvdllSQTJ5bzh5ckRzQ2ZTek1FeEgyc1F3ckNoby9aTnlTeGVweHA1?= =?utf-8?B?ZzUyQkNxUkdnQlNpMGdoVkM2NStLVk1WQno5OHJ5WmhSa3RBL3hzcE9KK2hG?= =?utf-8?B?d1JnYkdRdndrd3ZVYU80NThCTVhsbkt0SEg4QUlxZStqcTRmRFV0bFRVV3dZ?= =?utf-8?B?dVpvS3FEVktOWGxWOTdRTTJndHF3RVdUNzNrSFkzTWp4TU8zR2NsTFFEdzVs?= =?utf-8?B?Q1pyUStNU0pLeWk2SVF5Qm5qMTJzMVR5NXlxUEttK2hSYTFTbXVJdWVhQTUw?= =?utf-8?B?OFp2YUY4ckJDbUptYkVtdUFGVUlXOTFhNjcxL1RPRTFCTnBHWWd6TTB5K3d0?= =?utf-8?B?d2ZHeTA4NXRXRk9QVVhXejY0WFVvTnNkMGFvK0Y0TTc3RndPVy9EejRQb204?= =?utf-8?B?QTFOMUhwcDFCRTFySElGekdYcUpVSnRsRk9mY1hEVWNtMGlLeU5aOEwvR0lM?= =?utf-8?B?ZzQyM0o4NEVNSXBvRlVqbEpjZVl3Y0R6SW5VbUltVGhxWG1Ic3ZORzBtMWxI?= =?utf-8?B?T0FzVEk3RmdLUVZrWkplR3I4c281UWltd0Y2a3I2azh2RzFlSWU2bzNOb1VH?= =?utf-8?B?U0MxdlYwanNSbS9oTGh0UDhTU3NZSy9yT2JJUk5HK2NkQUFGZTJmR0V5a1lU?= =?utf-8?B?RGE4SmxEaTR6Z3d5dlF6SVlEbnpONnB0QndnaEVVeGNaY2FNZlBWeGM0eVVs?= =?utf-8?Q?c2atfkCu06tzvmh1WG5Z7FSnLFFDFAjt5GTgtA6UZEso?= X-Microsoft-Antispam-Message-Info: F2NNrVaWEvcW4Ub9fM6XWQPUjVqqNki+1fapwDL+NI5LHvmTOoPbajrVUIhQeJ9h2vjoLZqC06EgwST9QXbu5KPhFPLD1Z3zWffpoR41dZtCpyPwLSmPqR1PPDd3dDXY/6BjNW6F31CeVZKFrSrdMNQ5NkUwtwAtyrf+T/HiqO4xBOpst++vZ+/rzYrype0f X-Microsoft-Exchange-Diagnostics: 1; DM6PR15MB2394; 6:98P/2vvGoXI6xrHlWhXbcnjpuCJaz3kDvktvRM7fdcTGnodYFFkVAprY8qx7o9QgwYnZ9n7lwMCSfznwY0PCcCbgxFWQGyLEBQtEnsC6IumRcGMy2PGUtcAoATDDPRYJ+mM5LXyCIy+nWgydgzcSoTGqwTmP5c32vKoLPffh7U5Ri+9Q6N8UIB2bAMYCzYJ+t69mgscekYMPEUesLZJOMTD+Pq/E6Ynptoa973HkUoO+V/M/cV+yKWXGWA1+GVEQRDu7RyjhrH0+/i8Gm87rrr1Em0Eqq+GoVOI4OtxurB2elFKS8+ok16zk8z6jloBjH0iaB+Rr/l754giW/TsAiO401caw7K2Ch7lOYtedgniYxcQmHd9UJ59fKX1vI48Ep7ADvgfh4jsvekVo4ekABVe747LXE0Pq3rJUA6BBGVjDMwE1kF4aoRVXcaKnDxeScmOxeWFogDCpKPAviaGTAA==; 5:M/PCmhVX2h3WU2cdbj8r9WgJnRlm6hPWZ/rGx2dzUs6Ua/UiOeWF3T7V/f9zj6NO48eOqNRregpVEy1MOOVDiaDjj47Kvo/d1MIef1U12N3XrUyBvZosNzi2VkcfvSo+KyvLdOt65TxIlu1+fVfstnbbSA+MANwDC7ZV3m5qzDk=; 24:mVG9OrFh/XEgBH6rRkqp9xI0DExuxHvbBw5bpy8N9I15tYvCX7zZ1zdfvlJn3fIdPP8BM1BMXfWV9MLudjsMKUec2Vg/7wJIEHKiXquptBA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR15MB2394; 7:R21XAOx4gtFfuODnkCoxOSyTZXixSn8e0VmEjz/uGdzDcQK7aJZR3FU3KNI9AFu3x0SJlqB24EUUB2794uhIT8dBlwf5ulphkgTDIZPkK1E/o+Gbbbk1AKmf4GUjXn6fHDxtHrp96QYLd9UStgLRisCivCrmw8/U/661cWqFSDnAjy6C601hrvdm+J7ngrrzzFKSRJAAkJUMhUHHGLh3c8RpjMh+A44N2dCK/L8EGl1Y96woCy3mziyZ4Peq6rKS X-MS-Office365-Filtering-Correlation-Id: cfe1f508-4e8c-4f92-37a3-08d5c709fa5b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2018 15:20:00.4833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cfe1f508-4e8c-4f92-37a3-08d5c709fa5b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2394 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes On 2018-05-31 10:36 AM, Simon Marchi wrote: > On 2018-05-31 05:23, Uros Bizjak wrote: >> On Wed, May 30, 2018 at 4:53 PM, Simon Marchi wrote: >>> Does Alpha even have hardware breakpoints?  If not, I would suggest >>> defining GDB_ARCH_IS_TRAP_HWBKPT to 0 for __alpha__.  It would get >>> rid of the error, and be more exact (no si_code can mean "hardware >>> breakpoint" on alpha). >> >> I didn't find any mentions of hardware breakpoint support in Alpha >> Architecture Handbook v.4. >> >> Please note that save_stop_reason from linux-nat.c has some code to >> detect ambigous si_code, where si_code is both TRAP_BRKPT and >> TRAP_HWBKPT, and returns TARGET_STOPPED_BY_SW_BREAKPOINT in this case. >> So, if we don't define anything for __alpha__ in nat/linux-ptrace.h, >> we get the same result. > > TRAP_BKPT and TRAP_HWBKPT are different, so this will never happen with the default definitions of GDB_ARCH_IS_TRAP_BRKPT/GDB_ARCH_IS_TRAP_HWBKPT.  Since the kernel for alpha never sets si_code to TRAP_HWBKPT, it means we'll never get in to the HW breakpoint branch, which is fine. > > In short, the patch LGTM. > >> I have tested the attached patch, and resulting gdb works OK for me. > > Thanks! > > Simon Since Uros doesn't have write access, I wrote a commit log and pushed the patch. Simon From 8a60efe714e636c9f958058a8dfb12de81bdcbfa Mon Sep 17 00:00:00 2001 From: Uros Bizjak Date: Thu, 31 May 2018 11:18:02 -0400 Subject: [PATCH] Fix Alpha native GDB build [Commit log by Simon Marchi] I get this error: CXX linux-nat.o /home/simark/src/binutils-gdb/gdb/linux-nat.c: In function 'void save_stop_reason(lwp_info*)': /home/simark/src/binutils-gdb/gdb/linux-nat.c:2718:9: error: duplicated 'if' condition [-Werror=duplicated-cond] else if (GDB_ARCH_IS_TRAP_HWBKPT (siginfo.si_code)) ^~ In file included from /home/simark/src/binutils-gdb/gdb/linux-nat.c:31:0: /home/simark/src/binutils-gdb/gdb/nat/linux-ptrace.h:173:41: note: previously used here # define GDB_ARCH_IS_TRAP_BRKPT(X) ((X) == TRAP_BRKPT) ~~~~~^~~~~~~~~~~~~~ /home/simark/src/binutils-gdb/gdb/linux-nat.c:2709:13: note: in expansion of macro 'GDB_ARCH_IS_TRAP_BRKPT' else if (GDB_ARCH_IS_TRAP_BRKPT (siginfo.si_code)) ^~~~~~~~~~~~~~~~~~~~~~ For Alpha, we currently define GDB_ARCH_IS_TRAP_BRKPT and GDB_ARCH_IS_TRAP_HWBKPT both to ((X) == TRAP_BRKPT), which causes the two if branches to be duplicated. Alpha doesn't have hardware breakpoints, so the Linux kernel for Alpha never sets si_code to TRAP_HWBKPT. We can just remove the special definitions of these macros for __alpha__ and rely on the default ones. Since the kernel will never report TRAP_HWBKPT, we will just never enter the "hardware breakpoint" branch on Alpha (which is fine since it doesn't have them). gdb/ChangeLog: * nat/linux-ptrace.h [__alpha__] (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove definitions. --- gdb/ChangeLog | 6 ++++++ gdb/nat/linux-ptrace.h | 5 ----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c6c862f..8af7e67 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2018-05-31 Uros Bizjak + + * nat/linux-ptrace.h [__alpha__] + (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove + definitions. + 2018-05-31 Maciej W. Rozycki * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to diff --git a/gdb/nat/linux-ptrace.h b/gdb/nat/linux-ptrace.h index dc180fb..98b44a8 100644 --- a/gdb/nat/linux-ptrace.h +++ b/gdb/nat/linux-ptrace.h @@ -156,8 +156,6 @@ struct buffer; Beginning with Linux 4.6, the MIPS port reports proper TRAP_BRKPT and TRAP_HWBKPT codes, so we also match them. - The Alpha kernel uses TRAP_BRKPT for all traps. - The generic Linux target code should use GDB_ARCH_IS_TRAP_* instead of TRAP_* to abstract out these peculiarities. */ #if defined __i386__ || defined __x86_64__ @@ -169,9 +167,6 @@ struct buffer; #elif defined __mips__ # define GDB_ARCH_IS_TRAP_BRKPT(X) ((X) == SI_KERNEL || (X) == TRAP_BRKPT) # define GDB_ARCH_IS_TRAP_HWBKPT(X) ((X) == SI_KERNEL || (X) == TRAP_HWBKPT) -#elif defined __alpha__ -# define GDB_ARCH_IS_TRAP_BRKPT(X) ((X) == TRAP_BRKPT) -# define GDB_ARCH_IS_TRAP_HWBKPT(X) ((X) == TRAP_BRKPT) #else # define GDB_ARCH_IS_TRAP_BRKPT(X) ((X) == TRAP_BRKPT) # define GDB_ARCH_IS_TRAP_HWBKPT(X) ((X) == TRAP_HWBKPT)