From patchwork Mon Feb 17 16:57:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aktemur, Tankut Baris" X-Patchwork-Id: 38164 Received: (qmail 122375 invoked by alias); 17 Feb 2020 17:01:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118295 invoked by uid 89); 17 Feb 2020 17:00:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=coded X-HELO: mga18.intel.com Received: from mga18.intel.com (HELO mga18.intel.com) (134.134.136.126) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 16:59:42 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 08:59:24 -0800 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga006.fm.intel.com with ESMTP; 17 Feb 2020 08:59:22 -0800 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 01HGxLNf028193; Mon, 17 Feb 2020 16:59:21 GMT Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 01HGxLli027113; Mon, 17 Feb 2020 17:59:21 +0100 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 01HGxLrk027109; Mon, 17 Feb 2020 17:59:21 +0100 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: palves@redhat.com Subject: [PATCH v2 17/58] gdbserver: turn target op 'read_auxv' into a method Date: Mon, 17 Feb 2020 17:57:25 +0100 Message-Id: <8d3b7f97e66a1ff5ae9a640de7691096f2b53363.1581956646.git.tankut.baris.aktemur@intel.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes gdbserver/ChangeLog: 2020-02-10 Tankut Baris Aktemur Turn process_stratum_target's read_auxv op into a method of process_target. * target.h (class process_stratum_target): Remove the target op. (struct process_target): Add the target op. Also add 'supports_read_auxv'. * target.cc (process_target::read_auxv): Define. (process_target::supports_read_auxv): Define. Update the derived classes and callers below. * server.cc (handle_qxfer_auxv): Update. (handle_query): Update. * linux-low.cc (linux_target_ops): Update. (linux_process_target::supports_read_auxv): Define. (linux_read_auxv): Turn into ... (linux_process_target::read_auxv): ... this. * linux-low.h (class linux_process_target): Update. * lynx-low.cc (lynx_target_ops): Update. * nto-low.cc (nto_target_ops): Update. (nto_process_target::supports_read_auxv): Define. (nto_read_auxv): Turn into ... (nto_process_target::read_auxv): ... this. * nto-low.h (class nto_process_target): Update. * win32-low.cc (win32_target_ops): Update. --- gdbserver/linux-low.cc | 14 ++++++++++---- gdbserver/linux-low.h | 5 +++++ gdbserver/lynx-low.cc | 1 - gdbserver/nto-low.cc | 12 +++++++++--- gdbserver/nto-low.h | 5 +++++ gdbserver/server.cc | 6 +++--- gdbserver/target.cc | 13 +++++++++++++ gdbserver/target.h | 16 +++++++++------- gdbserver/win32-low.cc | 1 - 9 files changed, 54 insertions(+), 19 deletions(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 3d02cb5431c..47ac768d929 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -5919,11 +5919,18 @@ linux_process_target::request_interrupt () ::kill (-signal_pid, SIGINT); } +bool +linux_process_target::supports_read_auxv () +{ + return true; +} + /* Copy LEN bytes from inferior's auxiliary vector starting at OFFSET to debugger memory starting at MYADDR. */ -static int -linux_read_auxv (CORE_ADDR offset, unsigned char *myaddr, unsigned int len) +int +linux_process_target::read_auxv (CORE_ADDR offset, unsigned char *myaddr, + unsigned int len) { char filename[PATH_MAX]; int fd, n; @@ -7317,7 +7324,7 @@ linux_get_auxv (int wordsize, CORE_ADDR match, CORE_ADDR *valp) gdb_assert (wordsize == 4 || wordsize == 8); - while ((*the_target->read_auxv) (offset, data, 2 * wordsize) == 2 * wordsize) + while (the_target->pt->read_auxv (offset, data, 2 * wordsize) == 2 * wordsize) { if (wordsize == 4) { @@ -7369,7 +7376,6 @@ linux_get_hwcap2 (int wordsize) static linux_process_target the_linux_target; static process_stratum_target linux_target_ops = { - linux_read_auxv, linux_supports_z_point_type, linux_insert_point, linux_remove_point, diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h index 197a0bbe1d4..0130c22ce27 100644 --- a/gdbserver/linux-low.h +++ b/gdbserver/linux-low.h @@ -309,6 +309,11 @@ public: void look_up_symbols () override; void request_interrupt () override; + + bool supports_read_auxv () override; + + int read_auxv (CORE_ADDR offset, unsigned char *myaddr, + unsigned int len) override; }; #define get_thread_lwp(thr) ((struct lwp_info *) (thread_target_data (thr))) diff --git a/gdbserver/lynx-low.cc b/gdbserver/lynx-low.cc index 8b5300f08c2..bf73e81993e 100644 --- a/gdbserver/lynx-low.cc +++ b/gdbserver/lynx-low.cc @@ -729,7 +729,6 @@ static lynx_process_target the_lynx_target; /* The LynxOS target_ops vector. */ static process_stratum_target lynx_target_ops = { - NULL, /* read_auxv */ NULL, /* supports_z_point_type */ NULL, /* insert_point */ NULL, /* remove_point */ diff --git a/gdbserver/nto-low.cc b/gdbserver/nto-low.cc index d60f72affd5..d828fa7a607 100644 --- a/gdbserver/nto-low.cc +++ b/gdbserver/nto-low.cc @@ -755,14 +755,21 @@ nto_process_target::request_interrupt () TRACE ("Error stopping inferior.\n"); } +bool +nto_process_target::supports_read_auxv () +{ + return true; +} + /* Read auxiliary vector from inferior's memory into gdbserver's buffer MYADDR. We always read whole auxv. Return number of bytes stored in MYADDR buffer, 0 if OFFSET > 0 or -1 on error. */ -static int -nto_read_auxv (CORE_ADDR offset, unsigned char *myaddr, unsigned int len) +int +nto_process_target::read_auxv (CORE_ADDR offset, unsigned char *myaddr, + unsigned int len) { int err; CORE_ADDR initial_stack; @@ -943,7 +950,6 @@ nto_sw_breakpoint_from_kind (int kind, int *size) static nto_process_target the_nto_target; static process_stratum_target nto_target_ops = { - nto_read_auxv, nto_supports_z_point_type, nto_insert_point, nto_remove_point, diff --git a/gdbserver/nto-low.h b/gdbserver/nto-low.h index c6e0c295662..e135dd3b68a 100644 --- a/gdbserver/nto-low.h +++ b/gdbserver/nto-low.h @@ -79,6 +79,11 @@ public: int len) override; void request_interrupt () override; + + bool supports_read_auxv () override; + + int read_auxv (CORE_ADDR offset, unsigned char *myaddr, + unsigned int len) override; }; /* The inferior's target description. This is a global because the diff --git a/gdbserver/server.cc b/gdbserver/server.cc index bc497f87b7f..f13061c871b 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -1442,13 +1442,13 @@ handle_qxfer_auxv (const char *annex, gdb_byte *readbuf, const gdb_byte *writebuf, ULONGEST offset, LONGEST len) { - if (the_target->read_auxv == NULL || writebuf != NULL) + if (!the_target->pt->supports_read_auxv () || writebuf != NULL) return -2; if (annex[0] != '\0' || current_thread == NULL) return -1; - return (*the_target->read_auxv) (offset, readbuf, len); + return the_target->pt->read_auxv (offset, readbuf, len); } /* Handle qXfer:exec-file:read. */ @@ -2374,7 +2374,7 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p) strcat (own_buf, ";qXfer:libraries:read+"); } - if (the_target->read_auxv != NULL) + if (the_target->pt->supports_read_auxv ()) strcat (own_buf, ";qXfer:auxv:read+"); if (the_target->qxfer_siginfo != NULL) diff --git a/gdbserver/target.cc b/gdbserver/target.cc index dd9ee8dfd47..97e9d4ac507 100644 --- a/gdbserver/target.cc +++ b/gdbserver/target.cc @@ -414,3 +414,16 @@ process_target::look_up_symbols () { /* Nop. */ } + +bool +process_target::supports_read_auxv () +{ + return false; +} + +int +process_target::read_auxv (CORE_ADDR offset, unsigned char *myaddr, + unsigned int len) +{ + gdb_assert_not_reached ("target op read_auxv not supported"); +} diff --git a/gdbserver/target.h b/gdbserver/target.h index 234a183427e..cd11da670ca 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -70,13 +70,6 @@ class process_target; shared code. */ struct process_stratum_target { - /* Read auxiliary vector data from the inferior process. - - Read LEN bytes at OFFSET into a buffer at MYADDR. */ - - int (*read_auxv) (CORE_ADDR offset, unsigned char *myaddr, - unsigned int len); - /* Returns true if GDB Z breakpoint type TYPE is supported, false otherwise. The type is coded as follows: '0' - software-breakpoint @@ -474,6 +467,15 @@ public: /* Send an interrupt request to the inferior process, however is appropriate. */ virtual void request_interrupt () = 0; + + /* Return true if the read_auxv target op is supported. */ + virtual bool supports_read_auxv (); + + /* Read auxiliary vector data from the inferior process. + + Read LEN bytes at OFFSET into a buffer at MYADDR. */ + virtual int read_auxv (CORE_ADDR offset, unsigned char *myaddr, + unsigned int len); }; extern process_stratum_target *the_target; diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 098da30017d..2d617d889ec 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -1838,7 +1838,6 @@ win32_sw_breakpoint_from_kind (int kind, int *size) static win32_process_target the_win32_target; static process_stratum_target win32_target_ops = { - NULL, /* read_auxv */ win32_supports_z_point_type, win32_insert_point, win32_remove_point,