From patchwork Thu Nov 19 16:02:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jose E. Marchesi" X-Patchwork-Id: 9746 Received: (qmail 47758 invoked by alias); 19 Nov 2015 15:55:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 47741 invoked by uid 89); 19 Nov 2015 15:55:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 Nov 2015 15:55:20 +0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAJFtHQk019315 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Nov 2015 15:55:18 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id tAJFtGfs022683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Thu, 19 Nov 2015 15:55:17 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tAJFtGVx017687 for ; Thu, 19 Nov 2015 15:55:16 GMT Received: from termi.oracle.com (/10.175.241.155) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 19 Nov 2015 07:55:16 -0800 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: gdb-patches@sourceware.org Subject: [PATCH] [SPARC] callfuncs.exp: avoid spurious register differences in sparc64 targets. Date: Thu, 19 Nov 2015 17:02:46 +0100 Message-ID: <87ziyam0yh.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Hi all! Ok to commit? commit 50fa72dabc43ba7fabbd5d213013d78cd22e2342 Author: Jose E. Marchesi Date: Thu Nov 19 10:55:06 2015 -0500 callfuncs.exp: avoid spurious register differences in sparc64 targets. The Linux kernel disables the FPU upon returning to userland. This introduces spurious failures in the register preservation tests in callfuncs.exp, since the pstate.PEF bit gets cleared after system calls. This patch filters out the pstate register in sparc64-*-linux-gnu targets, so the relevant tests are no longer fooled and pass. gdb/testsuite/ChangeLog: 2015-11-19 Jose E. Marchesi * gdb.base/callfuncs.exp (fetch_all_registers): Filter out the pstate register when comparing registers values in sparc64-*-linux-gnu targets to avoid spurious differences. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 14c4b41..e712bc5 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-11-19 Jose E. Marchesi + + * gdb.base/callfuncs.exp (fetch_all_registers): Filter out the + pstate register when comparing registers values in + sparc64-*-linux-gnu targets to avoid spurious differences. + 2015-11-17 Dominik Vogt * lib/dwarf.exp (_note): Fix left shift of negative value. diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp index fda3cb7..28e2fe1 100644 --- a/gdb/testsuite/gdb.base/callfuncs.exp +++ b/gdb/testsuite/gdb.base/callfuncs.exp @@ -254,6 +254,16 @@ proc fetch_all_registers {test} { } exp_continue } + -re "^pstate\[ \t\]+\[^\r\n\]+\r\n" { + if [istarget "sparc64-*-linux-gnu"] { + # Filter out the pstate register, since in sparc64 + # targets the Linux kernel disables pstate.PEF when + # returning from traps, giving spurious differences. + } else { + lappend all_registers_lines $expect_out(0,string) + } + exp_continue + } -re "^last_break\[ \t\]+\[^\r\n\]+\r\n" { if [istarget "s390*-*-*"] { # Filter out last_break which is read-only,