From patchwork Mon Apr 28 09:44:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Arnez X-Patchwork-Id: 699 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 2E2DF36007C for ; Mon, 28 Apr 2014 02:44:47 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id E9CB86324E586; Mon, 28 Apr 2014 02:44:46 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id B0C1C6324E5AF for ; Mon, 28 Apr 2014 02:44:46 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=V51n5 PIE3Ze06ozSNc7FuFQolp0lhRGW1m7v2JN/3GJrAij/WddjIoe346nxzRtzXSH7p hn5paOos0iBItsQXYKDQKVrg3hee2Fqekmc5noifs7sc+jZHadDsNjbhwlW4X9eX 3wepvW6L6crmRCgIoJpOrX59cmaFA5h8K7Wykk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=db8B7Bw+cc6 oHPWEebu3RLtw6Y4=; b=isT59IBJkRblCvm9Rqca7VFPHh28H6wtYGptDMfNiND ouFvZ362yvWPdRKTLgoVk3HUjYJwjGtRZcjmn2UDftNaxWX9yMa8UlQ57H2wFxAQ XeLAsyPYP36Si7CfLzV2GvZ5IKUe3m/SvHc/ernT716hSZ3kGbzZ6jChhaGP/FlI = Received: (qmail 25105 invoked by alias); 28 Apr 2014 09:44:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25093 invoked by uid 89); 28 Apr 2014 09:44:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp12.uk.ibm.com Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 28 Apr 2014 09:44:43 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 28 Apr 2014 10:44:40 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 28 Apr 2014 10:44:39 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 768C11B08070 for ; Mon, 28 Apr 2014 10:44:46 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s3S9idun27459622 for ; Mon, 28 Apr 2014 09:44:39 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s3S9icqq015293 for ; Mon, 28 Apr 2014 03:44:38 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-188.boeblingen.de.ibm.com [9.152.212.188]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s3S9ibaQ015255; Mon, 28 Apr 2014 03:44:38 -0600 From: Andreas Arnez To: gdb-patches@sourceware.org Cc: Richard Earnshaw Subject: [RFC 03/23] AARCH64: Replace regset_alloc() invocations by static regset structures References: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> Date: Mon, 28 Apr 2014 11:44:37 +0200 In-Reply-To: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> (Andreas Arnez's message of "Mon, 28 Apr 2014 11:35:33 +0200") Message-ID: <87y4yp4wl6.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14042809-8372-0000-0000-0000097CD813 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in After removal of the regset_alloc invocations, the tdep fields 'gregset' and 'fpregset' become obsolete and are thus removed. gdb/ * aarch64-linux-tdep.c (aarch64_linux_gregset) (aarch64_linux_fpregset): New static regset structures. (aarch64_linux_regset_from_core_section): Drop dynamic allocation of regset structures. * aarch64-tdep.h (struct gdbarch_tdep): Remove 'gregset' and 'fpregset' fields. --- gdb/aarch64-linux-tdep.c | 29 +++++++++++++++-------------- gdb/aarch64-tdep.h | 4 ---- 2 files changed, 15 insertions(+), 18 deletions(-) diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 92d1248..6f52c8c 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -240,6 +240,18 @@ supply_fpregset_from_core (const struct regset *regset, aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) regbuf); } +/* Register set definitions. */ + +static const struct regset aarch64_linux_gregset = + { + NULL, supply_gregset_from_core, NULL + }; + +static const struct regset aarch64_linux_fpregset = + { + NULL, supply_fpregset_from_core, NULL + }; + /* Implement the "regset_from_core_section" gdbarch method. */ static const struct regset * @@ -247,25 +259,14 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch, const char *sect_name, size_t sect_size) { - struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); - if (strcmp (sect_name, ".reg") == 0 && sect_size == AARCH64_LINUX_SIZEOF_GREGSET) - { - if (tdep->gregset == NULL) - tdep->gregset = regset_alloc (gdbarch, supply_gregset_from_core, - NULL); - return tdep->gregset; - } + return &aarch64_linux_gregset; if (strcmp (sect_name, ".reg2") == 0 && sect_size == AARCH64_LINUX_SIZEOF_FPREGSET) - { - if (tdep->fpregset == NULL) - tdep->fpregset = regset_alloc (gdbarch, supply_fpregset_from_core, - NULL); - return tdep->fpregset; - } + return &aarch64_linux_fpregset; + return NULL; } diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h index 30a5ee3..78fb779 100644 --- a/gdb/aarch64-tdep.h +++ b/gdb/aarch64-tdep.h @@ -82,10 +82,6 @@ struct gdbarch_tdep /* And the size of each entry in the buf. */ size_t jb_elt_size; - /* Cached core file helpers. */ - struct regset *gregset; - struct regset *fpregset; - /* Types for AdvSISD registers. */ struct type *vnq_type; struct type *vnd_type;