diff mbox

[PING] Fix gdb.fortran/array-element.exp failures.

Message ID 87r4048546.fsf_-_@krisman.be
State New
Headers show

Commit Message

Gabriel Krisman Bertazi Aug. 26, 2014, 12:30 a.m. UTC
Ping.

 2014-08-17  Gabriel Krisman Bertazi  <gabriel@krisman.be>

 	* gdb.fortran/array-element.exp: Remove wrong "continue"
 	  command.  Simplify test case.

Comments

Gabriel Krisman Bertazi Sept. 4, 2014, 7:31 p.m. UTC | #1
Ping.  Is this ok for approval?

>  2014-08-17  Gabriel Krisman Bertazi  <gabriel@krisman.be>
>
>  	* gdb.fortran/array-element.exp: Remove wrong "continue"
>  	  command.  Simplify test case.
>
> diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp
> index 579db03..1ac3623 100644
> --- a/gdb/testsuite/gdb.fortran/array-element.exp
> +++ b/gdb/testsuite/gdb.fortran/array-element.exp
> @@ -31,18 +31,9 @@ if ![runto sub_] then {
>      continue
>  }
>  
> -set bp_location [gdb_get_line_number "continue"]
> -gdb_test "break $bp_location" \
> -    "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \
> -    "breakpoint at continue"
> -
> -gdb_test "continue" \
> -    "Continuing\\..*Breakpoint.*" \
> -    "continue to breakpoint"
> -gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
> +gdb_breakpoint [gdb_get_line_number "continue"]
> +gdb_continue_to_breakpoint "continue"
>  
> -gdb_test "continue" \
> -    "Continuing\\..*Breakpoint.*" \
> -    "continue to breakpoint once again"
> +gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
>  gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"
Joel Brobecker Sept. 9, 2014, 1:09 p.m. UTC | #2
Gabriel,

>  2014-08-17  Gabriel Krisman Bertazi  <gabriel@krisman.be>
> 
>  	* gdb.fortran/array-element.exp: Remove wrong "continue"
>  	  command.  Simplify test case.
> 

Sorry it's taking so much time to review your patch.

To help us out, it's useful to show what the patch does in practice.
In this case, I'd like to do what's not working before the patch
gets applied, and how things change once your patch is applied.
GDB transcripts before and after usually help with that.
Sergio Durigan Junior Sept. 9, 2014, 3:08 p.m. UTC | #3
On Tuesday, September 09 2014, Joel Brobecker wrote:

> To help us out, it's useful to show what the patch does in practice.
> In this case, I'd like to do what's not working before the patch
> gets applied, and how things change once your patch is applied.
> GDB transcripts before and after usually help with that.

BTW, and I am not invalidating your request, I applied and tested his
patch locally before my review, which showed me that the issue was
probably a thinko from the original author.

Nevertheless, it's always good to have more data :-).
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp
index 579db03..1ac3623 100644
--- a/gdb/testsuite/gdb.fortran/array-element.exp
+++ b/gdb/testsuite/gdb.fortran/array-element.exp
@@ -31,18 +31,9 @@  if ![runto sub_] then {
     continue
 }
 
-set bp_location [gdb_get_line_number "continue"]
-gdb_test "break $bp_location" \
-    "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \
-    "breakpoint at continue"
-
-gdb_test "continue" \
-    "Continuing\\..*Breakpoint.*" \
-    "continue to breakpoint"
-gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
+gdb_breakpoint [gdb_get_line_number "continue"]
+gdb_continue_to_breakpoint "continue"
 
-gdb_test "continue" \
-    "Continuing\\..*Breakpoint.*" \
-    "continue to breakpoint once again"
+gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
 gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"