From patchwork Mon Mar 30 19:48:03 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Petr Machata <pmachata@redhat.com>
X-Patchwork-Id: 5917
Received: (qmail 17192 invoked by alias); 30 Mar 2015 19:48:12 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 17173 invoked by uid 89); 30 Mar 2015 19:48:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00,
	SPF_HELO_PASS, SPF_PASS,
	T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by
	sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with
	(AES256-GCM-SHA384 encrypted) ESMTPS;
	Mon, 30 Mar 2015 19:48:08 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by
	mx1.redhat.com (Postfix) with ESMTPS id 1EA70350062;
	Mon, 30 Mar 2015 19:48:07 +0000 (UTC)
Received: from t540p (ovpn-116-42.ams2.redhat.com [10.36.116.42])	by
	int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4)
	with ESMTP id t2UJm46A009442	(version=TLSv1/SSLv3
	cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
	Mon, 30 Mar 2015 15:48:06 -0400
From: Petr Machata <pmachata@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line
	section
References: <87619mkpil.fsf@redhat.com>
	<21785.37797.271814.469027@ruffy2.mtv.corp.google.com>
Date: Mon, 30 Mar 2015 21:48:03 +0200
In-Reply-To: <21785.37797.271814.469027@ruffy2.mtv.corp.google.com>
	(Doug	Evans's message of "Mon, 30 Mar 2015 11:19:17 -0700")
Message-ID: <87pp7qjmh8.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0

Doug Evans <dje@google.com> writes:

>  > +	if { "$label" != "" } {
>  > +	    $label:
>  > +	}
>
> Should this be:
>
> 	if { "$label" != "" } {
> 	    _emit "$label:"
> 	}

No, it's calling the function named "$label:".  To define the label that
the user supplied.  Would this make it clearer?


Thanks,
Petr

--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -1165,6 +1165,7 @@ namespace eval Dwarf {
 	_section $section
 
 	if { "$label" != "" } {
+	    # Define the user-provided label at this point.
 	    $label:
 	}