diff mbox

Skip dlopen-libpthread.exp in cross testing

Message ID 87oau0wgmx.fsf@codesourcery.com
State New
Headers show

Commit Message

Yao Qi Sept. 28, 2014, 3:47 a.m. UTC
Pedro Alves <palves@redhat.com> writes:

> I think we should put an "error" call in build_executable_own_libs
> too, so that whoever adds the next test that uses this doesn't
> end up forgetting the same thing.

OK, how about this below?

Subject: [PATCH] Error in build_executable_own_libs for non-native target

gdb/testsuite:

2014-09-28  Yao Qi  <yao@codesourcery.com>

	* lib/prelink-support.exp (build_executable_own_libs): Error if
	the target isn't native.

Comments

Pedro Alves Sept. 29, 2014, 3:27 p.m. UTC | #1
On 09/28/2014 04:47 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> I think we should put an "error" call in build_executable_own_libs
>> too, so that whoever adds the next test that uses this doesn't
>> end up forgetting the same thing.
> 
> OK, how about this below?
> 
> Subject: [PATCH] Error in build_executable_own_libs for non-native target
> 
> gdb/testsuite:
> 
> 2014-09-28  Yao Qi  <yao@codesourcery.com>
> 
> 	* lib/prelink-support.exp (build_executable_own_libs): Error if
> 	the target isn't native.

Looks good, thanks.

Pedro Alves
Yao Qi Sept. 30, 2014, 4:01 a.m. UTC | #2
Pedro Alves <palves@redhat.com> writes:

> Looks good, thanks.

Great, two patches are pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/lib/prelink-support.exp b/gdb/testsuite/lib/prelink-support.exp
index a0fb12b..113a078 100644
--- a/gdb/testsuite/lib/prelink-support.exp
+++ b/gdb/testsuite/lib/prelink-support.exp
@@ -118,6 +118,10 @@  proc file_copy {src dest} {
 proc build_executable_own_libs {testname executable sources options {interp ""} {dir ""}} {
     global subdir
 
+    if { ![isnative] } {
+	error "This proc can be only used for native target."
+    }
+
     if {[build_executable $testname $executable $sources $options] == -1} {
 	return ""
     }