From patchwork Wed Aug 8 17:59:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 28797 Received: (qmail 938 invoked by alias); 8 Aug 2018 18:00:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 714 invoked by uid 89); 8 Aug 2018 18:00:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 18:00:01 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id C10661AC953 for ; Wed, 8 Aug 2018 12:59:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nSk3fo89taSeynSkLfM4Ax; Wed, 08 Aug 2018 12:59:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3HnItAirY+ADzyxTKG3nnpLn9wY2LRZPEp5dd5fqXeQ=; b=ykIjNBeqEJTp7WhvRx5WiphaMi 6RS2EjjcuI5zF+rXcTwO3d5OR7R9mHBv8KawmFc7MVfI30sTwMb5GoXwN/Hz/IMvW63uEiUe9JUJi fEa5P3QL2SQhHfxBcQllmLh5a; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:56936 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnSk2-000iJD-Qi; Wed, 08 Aug 2018 12:59:26 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Steve Ellcey , gdb-patches , simon.marchi@ericsson.com Subject: Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c) References: <1533742957.31481.2.camel@cavium.com> <87wot092xy.fsf@tromey.com> Date: Wed, 08 Aug 2018 11:59:25 -0600 In-Reply-To: (Simon Marchi's message of "Wed, 08 Aug 2018 13:39:18 -0400") Message-ID: <87o9ec91tu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 >>>>> "Simon" == Simon Marchi writes: Simon> Oops, sorry for the breakage. Tom's fix LGTM. Here's what I'm checking in. Tom commit 1ca8d27a27b8f05272764bf9ac1799cd86c74f52 Author: Tom Tromey Date: Wed Aug 8 11:57:39 2018 -0600 Check result of "write" Some distros enable _FORTIFY_SOURCE by default, which caught a failure to check the result of "write" in scoped_mmap-selftests.c. This patch fixes the problem. ChangeLog 2018-08-08 Tom Tromey * unittests/scoped_mmap-selftests.c: Check result of "write". diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 682520fc400..4181da6c01a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-08-08 Tom Tromey + + * unittests/scoped_mmap-selftests.c: Check result of "write". + 2018-08-08 Andrew Burgess PR gdb/18050: diff --git a/gdb/unittests/scoped_mmap-selftests.c b/gdb/unittests/scoped_mmap-selftests.c index d70a56a1862..e9d4afdffc5 100644 --- a/gdb/unittests/scoped_mmap-selftests.c +++ b/gdb/unittests/scoped_mmap-selftests.c @@ -91,7 +91,7 @@ test_normal () int fd = mkstemp (filename); SELF_CHECK (fd >= 0); - write (fd, "Hello!", 7); + SELF_CHECK (write (fd, "Hello!", 7) == 7); close (fd); gdb::unlinker unlink_test_file (filename);