Fix "list" when control characters are seen
Commit Message
>> static void foo (int x)
>> /* !
>> - !
>> +
Pedro> This seems pretty obscure without the context of the patch around.
Pedro> Should we add a comment here?
Good idea, how's this?
Tom
commit d20ed5fd574ce1b72543c2963fa53946eb2225de
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Jun 18 09:27:45 2019 -0600
Add comment to list0.h
Pedro suggested adding a comment to list0.h to explain the control
character.
Tested on x86-64 Fedora 29.
gdb/testsuite/ChangeLog
2019-06-18 Tom Tromey <tromey@adacore.com>
* gdb.base/list0.h: Add comment explaining control character.
Comments
On 6/18/19 4:29 PM, Tom Tromey wrote:
>>> static void foo (int x)
>>> /* !
>>> - !
>>> +
>
> Pedro> This seems pretty obscure without the context of the patch around.
>
> Pedro> Should we add a comment here?
>
> Good idea, how's this?
Looks great, thanks.
Pedro Alves
@@ -1,3 +1,7 @@
+2019-06-18 Tom Tromey <tromey@adacore.com>
+
+ * gdb.base/list0.h: Add comment explaining control character.
+
2019-06-18 Tom de Vries <tdevries@suse.de>
* boards/fission.exp: Break up long debug_flags line.
@@ -2,7 +2,7 @@
extern void bar(int);
static void foo (int x)
-/* !
+/* ! the next line has a control character, see PR symtab/24423.
! */
{