From patchwork Thu Feb 14 16:16:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 31474 Received: (qmail 47131 invoked by alias); 14 Feb 2019 16:17:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 46841 invoked by uid 89); 14 Feb 2019 16:17:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Apr, apr X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 16:17:04 +0000 Received: from svr-orw-mbx-06.mgc.mentorg.com ([147.34.90.206]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1guJh8-0003Dp-Sl from Thomas_Schwinge@mentor.com ; Thu, 14 Feb 2019 08:17:02 -0800 Received: from svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) by SVR-ORW-MBX-06.mgc.mentorg.com (147.34.90.206) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 14 Feb 2019 08:17:00 -0800 Received: from tftp-cs (147.34.91.1) by svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Thu, 14 Feb 2019 08:17:00 -0800 Received: by tftp-cs (Postfix, from userid 49978) id 43318C2320; Thu, 14 Feb 2019 08:17:00 -0800 (PST) From: Thomas Schwinge To: CC: Pedro Alves Subject: Re: [PATCH 18/18] -Wwrite-strings: Remove -Wno-write-strings In-Reply-To: <1491326751-16180-19-git-send-email-palves@redhat.com> References: <1491326751-16180-1-git-send-email-palves@redhat.com> <1491326751-16180-19-git-send-email-palves@redhat.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Thu, 14 Feb 2019 17:16:55 +0100 Message-ID: <87imxmibuw.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Tue, 4 Apr 2017 18:25:51 +0100, Pedro Alves wrote: > AFAIK GDB is now free from -Wwrite-strings warnings. A few warnings may > be left behind in some host-specific code Hey, GNU Hurd was the lucky one! ;-) > but those should be few and > easy to fix. Right. > * warning.m4 (build_warnings): Remove -Wno-write-strings. Pushed to master the attached commit 924514e11c21ac5a5805e7a14824b6f3182b2198 '[gdb, hurd] Address "ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]" diagnostics'. Grüße Thomas From 924514e11c21ac5a5805e7a14824b6f3182b2198 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Thu, 14 Feb 2019 10:22:28 +0100 Subject: [PATCH] [gdb, hurd] Address "ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]" diagnostics ... that appeared with 9bf2a700667c53003ece783c05e8b355801105f2 "-Wwrite-strings: Remove -Wno-write-strings". gdb/ * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg) (check_empty): Use "const char *". --- gdb/ChangeLog | 3 +++ gdb/gnu-nat.c | 9 +++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 71c61bc909..e427dda8a3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ 2019-02-14 Thomas Schwinge + * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg) + (check_empty): Use "const char *". + * gnu-nat.c (gnu_nat_target::detach): Instead of 'detach_inferior (pid)' call 'detach_inferior (find_inferior_pid (pid))'. diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 67cc95c68d..395b456ad7 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -2361,7 +2361,7 @@ gnu_write_inferior (task_t task, CORE_ADDR addr, mach_msg_type_number_t copy_count; int deallocate = 0; - char *errstr = "Bug in gnu_write_inferior"; + const char *errstr = "Bug in gnu_write_inferior"; struct vm_region_list *region_element; struct vm_region_list *region_head = NULL; @@ -2778,7 +2778,7 @@ show_thread_default_cmd (const char *args, int from_tty) } static int -parse_int_arg (const char *args, char *cmd_prefix) +parse_int_arg (const char *args, const char *cmd_prefix) { if (args) { @@ -2793,7 +2793,8 @@ parse_int_arg (const char *args, char *cmd_prefix) } static int -_parse_bool_arg (const char *args, char *t_val, char *f_val, char *cmd_prefix) +_parse_bool_arg (const char *args, const char *t_val, const char *f_val, + const char *cmd_prefix) { if (!args || strcmp (args, t_val) == 0) return 1; @@ -2809,7 +2810,7 @@ _parse_bool_arg (const char *args, char *t_val, char *f_val, char *cmd_prefix) _parse_bool_arg (args, "on", "off", cmd_prefix) static void -check_empty (const char *args, char *cmd_prefix) +check_empty (const char *args, const char *cmd_prefix) { if (args) error (_("Garbage after \"%s\" command: `%s'"), cmd_prefix, args); -- 2.19.2